Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1890] Require API root for KvK config #877

Merged
merged 1 commit into from
Dec 4, 2023
Merged

[#1890] Require API root for KvK config #877

merged 1 commit into from
Dec 4, 2023

Conversation

pi-sigma
Copy link
Contributor

@pi-sigma pi-sigma commented Dec 4, 2023

  • prevent calls to the KvK API if the KvK is not properly configured.
  • require field api_root for the KvK config

Taiga #1890

@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (97ca46d) 92.80% compared to head (f972109) 92.81%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #877   +/-   ##
========================================
  Coverage    92.80%   92.81%           
========================================
  Files          800      801    +1     
  Lines        27495    27511   +16     
========================================
+ Hits         25517    25533   +16     
  Misses        1978     1978

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi-sigma pi-sigma force-pushed the fix/1890-kvk-not-configured branch from 4b3da87 to f972109 Compare December 4, 2023 12:54
@pi-sigma pi-sigma marked this pull request as ready for review December 4, 2023 13:10
@pi-sigma pi-sigma requested a review from stevenbal December 4, 2023 13:10
@stevenbal stevenbal merged commit fb7829f into develop Dec 4, 2023
14 checks passed
@stevenbal stevenbal deleted the fix/1890-kvk-not-configured branch December 4, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenbal stevenbal stevenbal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pi-sigma @codecov-commenter @stevenbal