[#1898] Design profile page for businesses

[pi-sigma]

Taiga #1895

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (59dc8af) 92.81% compared to head (fc0d9d5) 92.82%.
Report is 2 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop     #875   +/-   ##
========================================
  Coverage    92.81%   92.82%           
========================================
  Files          803      803           
  Lines        27531    27559   +28     
========================================
+ Hits         25553    25581   +28     
  Misses        1978     1978           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jiromaykin]

Something that needs extra checking: is the "None" value removed from all potentially empty fields in case they're empty? Needs to be an empty string and it preferably should not take up any space in the frontend.

[jiromaykin]

I am approving this for the front-end at least.

[stevenbal]

Looks good, I do have some questions (might be the case that this is by design, but I just want to double check):

• There is a bewerk button above voorkeur voor meldingen, bus only ontvang meldingen over can be edited and communicatiekanaal cannot be edited?
  

• bekijk alle gegevens is present in the design but I don't think it's implemented?

• I couldn't find email anywhere in the profile?

[jiromaykin]

• bekijk alle gegevens is present in the design but I don't think it's implemented?

That's a good question @stevenbal ; I am not sure there is actually any more data to show for Bedrijven, so perhaps @pi-sigma can answer this.

• I couldn't find email anywhere in the profile?

In future there is the wish to also add SMS/textmessaging but this functionality doesn't exist yet; not sure if this is too much of a problem but perhaps it does feel like people are given a choice to edit something here and then they are let down because they actually can't.
What do you think @alextreme ?

[alextreme]

• I couldn't find email anywhere in the profile?

In future there is the wish to also add SMS/textmessaging but this functionality doesn't exist yet; not sure if this is too much of a problem but perhaps it does feel like people are given a choice to edit something here and then they are let down because they actually can't. What do you think @alextreme ?

I discussed this and simply stating E-mail as per the design is fine.

[pi-sigma]

@jiromaykin We could retrieve and display various companay data via the kvk api, but this is not implemented and wasn't part of the spec, as far as I remember. If this is desired, we should create a new ticket and discuss what data should be retrieved.

@stevenbal You're right about both points; will fix and push final changes.

[stevenbal]

Looks good to me 👍