-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💄 [#1817] Show errors for selected documents #858
💄 [#1817] Show errors for selected documents #858
Conversation
03c35be
to
a2a3074
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #858 +/- ##
========================================
Coverage 92.80% 92.80%
========================================
Files 798 798
Lines 27422 27422
========================================
Hits 25449 25449
Misses 1973 1973 ☔ View full report in Codecov by Sentry. |
1734130
to
8143a46
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lingering log statement, otherwise looking good!
733f9be
to
14391b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the right track, some remarks about naming convention and coding style though.
src/open_inwoner/components/templates/components/Form/FileInput.html
Outdated
Show resolved
Hide resolved
src/open_inwoner/components/templates/components/Form/FileInput.html
Outdated
Show resolved
Hide resolved
567cae8
to
087b753
Compare
a0f19e7
to
f52e061
Compare
This looks good to me. As far as I can see, Sven's comments have been addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small last remarks.
Discussed with Paul and Sven because of the remarks and the draft-PR status, and I choose to merge this in due to the pending release. The remaining remarks are small enough that they can be resolved at a later moment. |
issue: https://taiga.maykinmedia.nl/project/open-inwoner/task/1817
(File limit can be set in Admin in http://localhost:8000/admin/openzaak/openzaakconfig/ >> Advanced options.
ISBN 111111110 test case: http://127.0.0.1:8000/mijn-aanvragen/2d24e2a4-201c-4803-a8fd-380f071dfdd8/status/
+part of issue: https://taiga.maykinmedia.nl/project/open-inwoner/task/1870