-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1706] Redesign personal info page #851
Conversation
d92a72f
to
4be6540
Compare
8304077
to
04cdbf4
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #851 +/- ##
===========================================
+ Coverage 92.79% 92.80% +0.01%
===========================================
Files 776 798 +22
Lines 26713 27439 +726
===========================================
+ Hits 24787 25465 +678
- Misses 1926 1974 +48 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I have even been able to review all the changes necessary - it's a lot of work, but here is a start.
Also: for content that is too wide for the card you would either need to make an ellipsis CSS style (with this combo: white-space: nowrap; overflow: hidden; text-overflow: ellipsis;
) OR you could change the number of columns for tablet size screens,
Perhaps get some inspiration here: https://github.com/maykinmedia/open-inwoner/pull/840/files
src/open_inwoner/scss/components/Profile/_personal-overview.scss
Outdated
Show resolved
Hide resolved
04cdbf4
to
a7c02fc
Compare
a7c02fc
to
99aa32c
Compare
Taiga #1706