Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1706] Redesign personal info page #851

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

pi-sigma
Copy link
Contributor

Taiga #1706

@pi-sigma pi-sigma force-pushed the feature/1706-design-personal-info branch from d92a72f to 4be6540 Compare November 23, 2023 08:35
@pi-sigma pi-sigma force-pushed the feature/1706-design-personal-info branch 4 times, most recently from 8304077 to 04cdbf4 Compare November 28, 2023 13:31
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ae363ca) 92.79% compared to head (99aa32c) 92.80%.
Report is 36 commits behind head on develop.

Files Patch % Lines
src/open_inwoner/accounts/models.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #851      +/-   ##
===========================================
+ Coverage    92.79%   92.80%   +0.01%     
===========================================
  Files          776      798      +22     
  Lines        26713    27439     +726     
===========================================
+ Hits         24787    25465     +678     
- Misses        1926     1974      +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi-sigma pi-sigma marked this pull request as ready for review November 28, 2023 13:47
Copy link
Contributor

@jiromaykin jiromaykin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I have even been able to review all the changes necessary - it's a lot of work, but here is a start.
Also: for content that is too wide for the card you would either need to make an ellipsis CSS style (with this combo: white-space: nowrap; overflow: hidden; text-overflow: ellipsis;) OR you could change the number of columns for tablet size screens,
Perhaps get some inspiration here: https://github.com/maykinmedia/open-inwoner/pull/840/files

Screenshot 2023-11-28 at 17 58 47

src/open_inwoner/templates/pages/profile/me.html Outdated Show resolved Hide resolved
src/open_inwoner/templates/pages/profile/me.html Outdated Show resolved Hide resolved
src/open_inwoner/templates/pages/profile/me.html Outdated Show resolved Hide resolved
src/open_inwoner/scss/components/Table/Tabled.scss Outdated Show resolved Hide resolved
@pi-sigma pi-sigma force-pushed the feature/1706-design-personal-info branch from 04cdbf4 to a7c02fc Compare December 1, 2023 09:49
@pi-sigma pi-sigma force-pushed the feature/1706-design-personal-info branch from a7c02fc to 99aa32c Compare December 1, 2023 10:38
@alextreme alextreme merged commit a42b82a into develop Dec 1, 2023
14 checks passed
@alextreme alextreme deleted the feature/1706-design-personal-info branch December 1, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants