✨ [#1838] Add zaaktypen select widget for Category admin #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenbal
force-pushed
the
feature/1838-category-visibility-zaaktypen
branch
3 times, most recently
from
e8c97f7 to
9f58b6b
Compare
stevenbal
force-pushed
the
feature/1837-category-visibility-digid-eherkenning
branch
from
d41d4b2 to
887d74f
Compare
Base automatically changed from
feature/1837-category-visibility-digid-eherkenning
to
develop
November 13, 2023 15:28
stevenbal
force-pushed
the
feature/1838-category-visibility-zaaktypen
branch
3 times, most recently
from
a60bd8c to
7c1a642
Compare
stevenbal
commented
Nov 13, 2023
stevenbal
commented
Nov 13, 2023
stevenbal
commented
Nov 13, 2023
stevenbal
changed the title
stevenbal
commented
Nov 14, 2023
src/open_inwoner/pdc/managers.py
Outdated
|
|
||
| months_since_last_zaak_per_zaaktype = {} | ||
| for case in cases: | ||
| resolve_zaak_type(case) |
There was a problem hiding this comment.
@alextreme this approach does mean that we have to do a fetch to get the zaaktype for each zaak, which isn't very efficient. I'm not sure how we could avoid this without something like an include parameter.
There was a problem hiding this comment.
Discussed: simplify this by storing the zaaktype URL on zaaktypeconfig and use that instead of identificatie on category, to avoid having to resolve here
|
Marked as draft again until performance issues have been resolved |
stevenbal
force-pushed
the
feature/1838-category-visibility-zaaktypen
branch
from
dfddb8f to
ff919cb
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #845 +/- ##
===========================================
- Coverage 92.84% 92.83% -0.01%
===========================================
Files 759 765 +6
Lines 26233 26486 +253
===========================================
+ Hits 24355 24589 +234
- Misses 1878 1897 +19 ☔ View full report in Codecov by Sentry. |
task: https://taiga.maykinmedia.nl/project/open-inwoner/task/1838 also disabled the diplaying of "selected" categories in the CategoriesPlugin
stevenbal
force-pushed
the
feature/1838-category-visibility-zaaktypen
branch
2 times, most recently
from
f01def1 to
ae04de6
Compare
alextreme
reviewed
Nov 20, 2023
| @@ -258,6 +258,10 @@ class SiteConfigurarionAdmin(OrderedInlineModelAdminMixin, SingletonModelAdmin): | |||
| ) | |||
| }, | |||
| ), | |||
| ( | |||
| _("Display options for authenticated users"), | |||
| {"fields": ("enable_categories_filtering_with_zaken",)}, | |||
There was a problem hiding this comment.
Graag verplaatsen naar de OpenZaak solo config model
alextreme
reviewed
Nov 20, 2023
alextreme
approved these changes
Nov 20, 2023
task: https://taiga.maykinmedia.nl/project/open-inwoner/task/1838 this is required, because otherwise the categories plugin will always apply the filter based on zaken for DigiD users, essentially overriding the other visibility flags for those users
stevenbal
force-pushed
the
feature/1838-category-visibility-zaaktypen
branch
2 times, most recently
from
48a7749 to
49b32d4
Compare
task: https://taiga.maykinmedia.nl/project/open-inwoner/task/1838 this is necessary to avoid performance issues when implementing personalization of categories based on zaaktypen
task: https://taiga.maykinmedia.nl/project/open-inwoner/task/1838 * move relevante_zaak_periode to ZaakTypeConfig, to have this fixed per zaaktype * use the ZaakTypeConfig.url that was added to figure out the identificaties, to avoid having to resolve a lot of zaaktypes
stevenbal
force-pushed
the
feature/1838-category-visibility-zaaktypen
branch
from
49b32d4 to
db38712
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
task: https://taiga.maykinmedia.nl/project/open-inwoner/task/1838