Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1817] Show errors for selected documents #839

Closed
wants to merge 5 commits into from

Conversation

jiromaykin
Copy link
Contributor

issue: https://taiga.maykinmedia.nl/project/open-inwoner/task/1817
depends on #833
so branched off from that.

@jiromaykin jiromaykin closed this Nov 7, 2023
@jiromaykin
Copy link
Contributor Author

Thought I was rebasing on the wrong branch, now reopening.

@jiromaykin jiromaykin reopened this Nov 7, 2023
@jiromaykin jiromaykin force-pushed the feature/1795-show-selected-documents-before-upload branch from b803203 to 5c3339e Compare November 8, 2023 11:29
@jiromaykin jiromaykin force-pushed the 1817-show-errors-for-selected-documents branch 2 times, most recently from 3d9f11c to 0475745 Compare November 8, 2023 12:12
@svenvandescheur svenvandescheur force-pushed the feature/1795-show-selected-documents-before-upload branch 2 times, most recently from f358945 to d0dc081 Compare November 17, 2023 15:48
@svenvandescheur svenvandescheur force-pushed the feature/1795-show-selected-documents-before-upload branch from b50e2b3 to 8bcc307 Compare November 17, 2023 16:42
@jiromaykin jiromaykin force-pushed the 1817-show-errors-for-selected-documents branch from 0475745 to c9533f2 Compare November 20, 2023 09:23
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (851e69d) 92.85% compared to head (c9533f2) 92.85%.

Additional details and impacted files
@@                                 Coverage Diff                                 @@
##           feature/1795-show-selected-documents-before-upload     #839   +/-   ##
===================================================================================
  Coverage                                               92.85%   92.85%           
===================================================================================
  Files                                                     759      759           
  Lines                                                   26315    26315           
===================================================================================
  Hits                                                    24436    24436           
  Misses                                                   1879     1879           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiromaykin jiromaykin force-pushed the feature/1795-show-selected-documents-before-upload branch from d8c6a53 to 57f273f Compare November 20, 2023 16:45
@svenvandescheur svenvandescheur force-pushed the feature/1795-show-selected-documents-before-upload branch 2 times, most recently from a30fbaf to b4f774e Compare November 21, 2023 15:29
Base automatically changed from feature/1795-show-selected-documents-before-upload to develop November 21, 2023 16:35
@jiromaykin
Copy link
Contributor Author

This PR needs to be renamed/deleted and rebased off of the new develop branch

@jiromaykin jiromaykin closed this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants