Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1656] Added CKEditor widget to category description field #789

Merged
merged 2 commits into from
Oct 3, 2023

Conversation

pi-sigma
Copy link
Contributor

Taiga #1656

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2023

Codecov Report

Merging #789 (1756cac) into develop (c9d4732) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #789   +/-   ##
========================================
  Coverage    92.93%   92.93%           
========================================
  Files          721      721           
  Lines        25037    25047   +10     
========================================
+ Hits         23268    23278   +10     
  Misses        1769     1769           
Files Coverage Δ
src/open_inwoner/pdc/admin/category.py 98.55% <100.00%> (+0.04%) ⬆️
src/open_inwoner/pdc/models/category.py 94.73% <100.00%> (+0.14%) ⬆️
src/open_inwoner/pdc/tests/test_views.py 100.00% <100.00%> (ø)
src/open_inwoner/pdc/views.py 85.39% <100.00%> (+0.11%) ⬆️
src/open_inwoner/utils/ckeditor.py 89.58% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pi-sigma pi-sigma marked this pull request as ready for review September 26, 2023 14:13
@Bartvaderkin Bartvaderkin self-requested a review September 28, 2023 10:35
Copy link
Contributor

@Bartvaderkin Bartvaderkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd expect this would also require some changes in the place this field is rendered.

If this widget produces/stores HTML it'd needs to be marked safe for output (or it'd get auto-escaped), and if it produces/stores Markdown then it needs to be rendered.

Maybe a simple test for that would be good?

@pi-sigma pi-sigma force-pushed the feature/1656-categories-wysiwyg branch from 642ffa3 to 59930e9 Compare September 29, 2023 12:06
@pi-sigma pi-sigma force-pushed the feature/1656-categories-wysiwyg branch from 59930e9 to b092fc6 Compare October 3, 2023 11:43
@pi-sigma pi-sigma force-pushed the feature/1656-categories-wysiwyg branch from b092fc6 to 1756cac Compare October 3, 2023 11:56
@alextreme alextreme merged commit ce04331 into develop Oct 3, 2023
@alextreme alextreme deleted the feature/1656-categories-wysiwyg branch October 3, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants