[#1567] Modified contact-forms to send new subject_code/onderwerp field to e-Suite
#788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 26, 2023 14:14
…werp` field to e-Suite
…rwerp` field to e-Suite
Bartvaderkin
requested review from
vaszig and
pi-sigma
and removed request for
vaszig
pi-sigma
reviewed
Sep 26, 2023
| @@ -507,6 +501,11 @@ def register_by_email(self, form, recipient_email): | |||
| def register_by_api(self, form, config: OpenKlantConfig): | |||
| assert config.has_api_configuration() | |||
|
|
|||
| try: | |||
| ztc = ZaakTypeConfig.objects.filter_case_type(self.case.zaaktype).get() | |||
| except ObjectDoesNotExist: | |||
There was a problem hiding this comment.
Does filter_case_type always return a single object?
There was a problem hiding this comment.
It does. It returns a queryset so it can be chained with other filters and situations that want a queryset (eg: filter_enabled_for_case_type() and filter_questions_enabled_for_case_type())
alextreme
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers both contact-forms: the configurations each get a new field with a code that gets sent to e-Suite/OpenKlant