Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ #184 - Implement inbox. #67

Merged
merged 11 commits into from
Dec 27, 2021
Merged

✨ #184 - Implement inbox. #67

merged 11 commits into from
Dec 27, 2021

Conversation

svenvandescheur
Copy link
Contributor

No description provided.

@svenvandescheur svenvandescheur mentioned this pull request Dec 24, 2021
Merged
annashamray
annashamray reviewed Dec 27, 2021
View reviewed changes
Copy link
Contributor

@annashamray annashamray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation about template tags is very nice and really helpful!
So as template tags tests 👍

I have a couple remarks about styling and that's it

src/open_inwoner/accounts/views/inbox.py Outdated Show resolved Hide resolved
src/open_inwoner/api/search/pagination.py Show resolved Hide resolved
src/open_inwoner/components/readme.md Show resolved Hide resolved
src/open_inwoner/components/templatetags/link_tags.py Outdated Show resolved Hide resolved
src/open_inwoner/scss/components/Sticky/_Sticky.scss Show resolved Hide resolved
src/open_inwoner/scss/components/List/_ListItem.scss Outdated Show resolved Hide resolved
annashamray
annashamray approved these changes Dec 27, 2021
View reviewed changes
Copy link
Contributor

@annashamray annashamray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@svenvandescheur svenvandescheur merged commit 972e00b into develop Dec 27, 2021
@annashamray annashamray deleted the feature/#184-messages branch May 9, 2022 10:07
alextreme added a commit that referenced this pull request Apr 8, 2024
@alextreme
[#2299] Due to django-digid-eherkenning issue #67
ebf3b0d
alextreme added a commit that referenced this pull request Apr 9, 2024
@alextreme
Merge pull request #1147 from maykinmedia/issue/2299-eherkenning-fix-…
783df9c 
…admin

[#2299] Due to django-digid-eherkenning issue #67
alextreme added a commit that referenced this pull request Apr 12, 2024
@alextreme
[#2299] Due to django-digid-eherkenning issue #67
63ec39e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annashamray annashamray annashamray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svenvandescheur @annashamray