-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1177] Show new plan contact count in menu #527
Conversation
66640cc
to
af25261
Compare
Codecov Report
@@ Coverage Diff @@
## develop #527 +/- ##
===========================================
+ Coverage 96.49% 96.51% +0.01%
===========================================
Files 542 545 +3
Lines 19332 19425 +93
===========================================
+ Hits 18655 18748 +93
Misses 677 677
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
45e2fb6
to
22feed8
Compare
@@ -6,6 +6,7 @@ | |||
class Migration(migrations.Migration): | |||
|
|||
dependencies = [ | |||
("accounts", "0055_user_image"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to edit this existing migration to get the migration test to work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One remark concerning the creator of the plan. Do we want to show the count to the creator as well?I would expect this only for the contact, since the creator is already aware of the plan at this point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in the previous comment, the number is shown for the creator as well.
22feed8
to
8b8cb91
Compare
1618f16
to
5d0683a
Compare
@vaszig Review is mostly about last two commits, although I had to rebase and force push. |
Can be merged |
No description provided.