Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1177] Show new plan contact count in menu #527

Merged
merged 5 commits into from
Mar 27, 2023

Conversation

Bartvaderkin
Copy link
Contributor

No description provided.

@Bartvaderkin Bartvaderkin force-pushed the feature/1177-new-plan-count branch from 66640cc to af25261 Compare March 13, 2023 10:15
@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2023

Codecov Report

Merging #527 (5d0683a) into develop (462a316) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #527      +/-   ##
===========================================
+ Coverage    96.49%   96.51%   +0.01%     
===========================================
  Files          542      545       +3     
  Lines        19332    19425      +93     
===========================================
+ Hits         18655    18748      +93     
  Misses         677      677              
Impacted Files Coverage Δ
...nwoner/plans/migrations/0013_auto_20230223_1115.py 100.00% <ø> (ø)
src/open_inwoner/accounts/models.py 97.91% <100.00%> (+0.04%) ⬆️
src/open_inwoner/accounts/tests/test_user.py 100.00% <100.00%> (ø)
...nwoner/plans/migrations/0014_auto_20230306_1017.py 100.00% <100.00%> (ø)
...er/plans/migrations/0015_plancontact_notify_new.py 100.00% <100.00%> (ø)
...ns/migrations/0016_alter_plancontact_notify_new.py 100.00% <100.00%> (ø)
src/open_inwoner/plans/models.py 98.61% <100.00%> (+0.08%) ⬆️
...c/open_inwoner/plans/tests/test_data_migrations.py 100.00% <100.00%> (ø)
src/open_inwoner/plans/tests/test_views.py 100.00% <100.00%> (ø)
src/open_inwoner/plans/views.py 97.90% <100.00%> (+0.02%) ⬆️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Bartvaderkin Bartvaderkin force-pushed the feature/1177-new-plan-count branch from 45e2fb6 to 22feed8 Compare March 13, 2023 11:31
@Bartvaderkin Bartvaderkin changed the title [#1177] Added through model for Plan.plan_contact m2m [#1177] Show new plan contact count in menu Mar 13, 2023
@Bartvaderkin Bartvaderkin marked this pull request as ready for review March 13, 2023 12:15
@Bartvaderkin Bartvaderkin requested a review from vaszig March 13, 2023 12:15
@@ -6,6 +6,7 @@
class Migration(migrations.Migration):

dependencies = [
("accounts", "0055_user_image"),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to edit this existing migration to get the migration test to work.

Copy link
Contributor

@vaszig vaszig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One remark concerning the creator of the plan. Do we want to show the count to the creator as well?I would expect this only for the contact, since the creator is already aware of the plan at this point.

@vaszig vaszig self-requested a review March 16, 2023 11:09
Copy link
Contributor

@vaszig vaszig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in the previous comment, the number is shown for the creator as well.

@Bartvaderkin Bartvaderkin force-pushed the feature/1177-new-plan-count branch from 22feed8 to 8b8cb91 Compare March 16, 2023 11:33
@Bartvaderkin Bartvaderkin force-pushed the feature/1177-new-plan-count branch from 1618f16 to 5d0683a Compare March 27, 2023 08:07
@Bartvaderkin Bartvaderkin requested a review from vaszig March 27, 2023 09:40
@Bartvaderkin
Copy link
Contributor Author

@vaszig Review is mostly about last two commits, although I had to rebase and force push.

@alextreme
Copy link
Member

Can be merged

@alextreme alextreme merged commit 558fd88 into develop Mar 27, 2023
@alextreme alextreme deleted the feature/1177-new-plan-count branch March 27, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants