💄 [#1164] Remove large space in footer and products on mobile #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiromaykin
force-pushed
the
fix/1164-remove-empty-children-in-footer-and-products
branch
from
baa7081 to
81a262d
Compare
jiromaykin
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #525 +/- ##
========================================
Coverage 96.52% 96.52%
========================================
Files 527 527
Lines 19023 19023
========================================
Hits 18361 18361
Misses 662 662 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Bartvaderkin
approved these changes
Mar 13, 2023
jiromaykin
force-pushed
the
fix/1164-remove-empty-children-in-footer-and-products
branch
from
15f5da7 to
7e99201
Compare
vaszig
approved these changes
Mar 14, 2023
alextreme
deleted the
fix/1164-remove-empty-children-in-footer-and-products
branch
jiromaykin
added a commit
that referenced
this pull request
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing: in Footer and Productpages there is too much space on mobile when paragraphs/divs are empty, mostly because of Grid gap.
see: https://taiga.maykinmedia.nl/project/open-inwoner/task/1164