[#1149] Implemented e-Suite form's open submission API and added to cases views #502
+412
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 27, 2023 11:18
Codecov Report
@@ Coverage Diff @@
## develop #502 +/- ##
=========================================
Coverage 96.51% 96.51%
=========================================
Files 514 523 +9
Lines 18569 18891 +322
=========================================
+ Hits 17921 18232 +311
- Misses 648 659 +11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Bartvaderkin
commented
Mar 1, 2023
| @@ -190,7 +190,7 @@ def test_get_role_name_display(self): | |||
| "voornamen": "", | |||
| }, | |||
| ) | |||
| expected = RolTypes.labels[RolTypes.natuurlijk_persoon] | |||
| expected = RolTypes.natuurlijk_persoon.label | |||
There was a problem hiding this comment.
This is because the zgw-consumers dependency update
Bartvaderkin
commented
Mar 1, 2023
Comment on lines
142
to
147
| def get_betrokkene_type_display(self): | ||
| return RolTypes.values[self.betrokkene_type] | ||
| return RolTypes[self.betrokkene_type].label | ||
|
|
||
| def get_omschrijving_generiek_display(self): | ||
| return RolOmschrijving.values[self.omschrijving_generiek] | ||
| return RolOmschrijving[self.omschrijving_generiek].label | ||
|
|
There was a problem hiding this comment.
This is because the zgw-consumers dependency update
vaszig
requested changes
Mar 1, 2023
|
@vaszig I removed the template variable and defined a fieldset for the OpenZaakConfigAdmin (also put the less interesting/huge things in a collapse group). |
vaszig
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: the zgw-consumers update was needed because e-Suite's returns bad pagination fields and I had to modify the
get_paginated_resultsutility. (and then it also had some changes itself in the way it ships the enum-choices).