-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1156] Add email and phonenumber to map and location cards #495
[#1156] Add email and phonenumber to map and location cards #495
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #495 +/- ##
===========================================
- Coverage 96.50% 96.50% -0.01%
===========================================
Files 514 514
Lines 18539 18562 +23
===========================================
+ Hits 17891 17913 +22
- Misses 648 649 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the map bubble, I think we'd want each property on it's own line like on the detail page? It is unusual to concatenate them together.
Jiro can do a double-check first |
Which CI node-version are we using? Should we keep NodeJS to the latest version or not? I don't know much about this yet :-) so I wonder how we will keep track of CI node and change Babel-parser to latest again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good to me now ,when viewed in browser.
In CI we are using node 12.22.12, which is not compatible with the latest version of babel-loader. I am not an expert concerning all these, but I know that it's better to pin a problematic package instead of upgrading node (which may cause problems to several packages then). |
No description provided.