[#1123] Feature/search functionality in plan list view #484
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #484 +/- ##
=========================================
Coverage 96.49% 96.50%
=========================================
Files 507 514 +7
Lines 18451 18561 +110
=========================================
+ Hits 17805 17913 +108
- Misses 646 648 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Works pretty good. One extra feedback on existing code: I'd expect the bold title in the 'Samenwerking' column in the list also clickable, and to have something in the aria-label of the arrow for accessibility.
Also I noticed the filter widgets don't have a regular label so I'd expect they need something as well.
|
@Bartvaderkin I tried to fix everything you mentioned except for the labels in filters. We have the same approach in actions filters (and maybe somewhere else too), so if we do need them I will create a separate task for all of them. |
| @@ -51,7 +51,7 @@ <h1 class="h1"> | |||
| <div class="table__item--notification-danger">{% trans "Actie vereist" %}</div> | |||
| {% endif %} | |||
| </td> | |||
| <td class="table__item">{% button text="" href=plan.get_absolute_url icon="arrow_forward" icon_outlined=True transparent=True %}</td> | |||
| <td class="table__item">{% button text="plan_detail" hide_text=True href=plan.get_absolute_url icon="arrow_forward" icon_outlined=True transparent=True %}</td> | |||
There was a problem hiding this comment.
I think this should be text=plan_detail (without quotes)
There was a problem hiding this comment.
For me it doesn't work without quotes, because it then means it's a variable but I need a string here.
When I have the quotes I see the following:
There was a problem hiding this comment.
My example was bad, I meant text=plan.title, or something else useful that makes sense to an accessibility user.
Having literally aria-label="plan_detail" doesn't seem helpful.
|
It is possible the action filters weren't there when this was initially reviewed for accessibility. Anyway, we need to have something for accessibility so if it is not part of this then a new ticket would be good. |
Yes, you are right. Task #1183 https://taiga.maykinmedia.nl/project/open-inwoner/task/1183 wad created. |
FYI, we use auto-submit forms (via js) in some components. We have this for
inputandselecthtml tags but afaik we only use it for select now, that's why I removed input selector. Another solution would be to add some time delay in order to be easier for the user to type something in the search input (before the form is auto-submitted).