Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♿ #1084 Check borders after accessibility changes #463

Merged
merged 9 commits into from
Feb 14, 2023
Merged

♿ #1084 Check borders after accessibility changes #463

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b4dd6c3
:wheelchair: add new mute style
jiromaykin Feb 7, 2023
3373cf7
:wheelchair: set decorative border-colors
jiromaykin Feb 9, 2023
7553e6c
:wheelchair: set decorative border-widths
jiromaykin Feb 9, 2023
02c4cef
:art: revert to original color
jiromaykin Feb 10, 2023
38a18fc
:art: revert to original colors
jiromaykin Feb 13, 2023
5319593
:art: revert to original color
jiromaykin Feb 13, 2023
a868248
:art: fix negative/positive color and borders for feedback labels
jiromaykin Feb 13, 2023
742cdb8
:art: add thin border variable
jiromaykin Feb 14, 2023
6726dd3
:art: add thin border variables for questionnaire list
jiromaykin Feb 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/open_inwoner/scss/components/Card/Card.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
.card {
--card-color-background: white;
--card-color-border: var(--color-mute);
--card-size-border: var(--border-width);
--card-color-border: var(--color-gray);
--card-size-border: 1px;
--card-size-dog-ear: var(--gutter-width);
--card-spacing: var(--spacing-large);

Expand Down
3 changes: 2 additions & 1 deletion src/open_inwoner/scss/components/Faq/_Faq.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@
}

&__list-item {
border: var(--border-width) solid var(--color-mute);
border: 1px solid var(--color-gray);
border-radius: var(--border-radius);
padding: var(--spacing-large);
}

Expand Down
2 changes: 1 addition & 1 deletion src/open_inwoner/scss/components/File/File.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
.file {
&__file {
align-items: center;
border: 1px solid var(--color-mute);
border: 1px solid var(--color-gray);
border-radius: var(--border-radius);
box-sizing: border-box;
display: flex;
Expand Down
6 changes: 3 additions & 3 deletions src/open_inwoner/scss/components/Questionnaire/Questionnaire.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,12 @@
}

&__list-item {
border-bottom: var(--border-width) solid var(--color-mute);
border-bottom: var(--border-width) solid var(--color-gray);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--border-width is 2px, maybe we should adhere to the card and dropdown buttons size -> 1px?
If so, let's create a variable for border size and set it to 1px, just to be reusable.

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right, I think this should become 1px as well; i will add to it.

padding: var(--spacing-large) var(--spacing-medium);
}

&__list-item:nth-child(1) {
border-top: var(--border-width) solid var(--color-mute);
border-top: var(--border-width) solid var(--color-gray);
}

h2 {
Expand All @@ -34,7 +34,7 @@
}

&__list-item:nth-child(2) {
border-top: var(--border-width) solid var(--color-mute);
border-top: var(--border-width) solid var(--color-gray);
}

&__list-item {
Expand Down
2 changes: 1 addition & 1 deletion src/open_inwoner/scss/views/App.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@
--color-font-accent: var(--color-gray-dark);

--color-body: var(--color-gray-dark);
// changed to #949494 to get the required 3:1 contrast ratio
// changed to #949494 to get the required 3:1 contrast ratio - in case of decorative border use var(--color-gray).
--color-mute: #949494;

/// Font.
Expand Down