[#1045] Added ZaakTypeInformatieObjectTypeConfig model and import #443
Conversation
Bartvaderkin
force-pushed
the
feature/1045-zaak-config-4-docs
branch
2 times, most recently
from
db5782a to
3943f9b
Compare
Codecov Report
@@ Coverage Diff @@
## develop #443 +/- ##
===========================================
+ Coverage 96.15% 96.18% +0.02%
===========================================
Files 489 492 +3
Lines 17114 17387 +273
===========================================
+ Hits 16456 16723 +267
- Misses 658 664 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| def has_add_permission(self, request, obj): | ||
| return False | ||
|
|
||
| def has_delete_permission(self, request, obj=None): |
There was a problem hiding this comment.
I am not sure maybe I didn't understand something but do we want to allow delete? I mean since we just show data that we retrieve and the next day it will be again there. This has to do generally with the delete operation (ZaakTypeConfig as well).
There was a problem hiding this comment.
Allowing delete like this is mostly for development and testing purposes, which is why I put it as superuser only. It is not essential but sometimes convenient.
src/open_inwoner/openzaak/catalog.py
Outdated
| @@ -202,6 +193,34 @@ def fetch_single_case_type(case_type_url: str) -> Optional[ZaakType]: | |||
| return case_type | |||
|
|
|||
|
|
|||
| @cache_result( | |||
There was a problem hiding this comment.
This function exists twice in the file, maybe after rebasing.
There was a problem hiding this comment.
Well spotted!
We really need to clean these at some point because what started as a few handy helper is growing out of control. I made a ticket 1096 on Taiga for this.
| verbose_name=_("Document upload URL"), | ||
| blank=True, | ||
| ) | ||
| document_upload_enabled = models.BooleanField( |
There was a problem hiding this comment.
Does this have to do with external uploading?We have the same below for ZaakTypeInformatieObjectTypeConfig and its name is a bit confusing, at least for me.
There was a problem hiding this comment.
I think the Taiga ticket 1045 explains best how it is supposed to work (it was my ticket so you might not have seen this.).
Maybe the name is not ideal; we can rename to fit the actual implementation (easy to migrate).
Bartvaderkin
changed the title
Bartvaderkin
changed the title
Bartvaderkin
force-pushed
the
feature/1045-zaak-config-4-docs
branch
from
3943f9b to
6eb8cc8
Compare
|
@vaszig I processed your feedback. Admittedly I also force-pushed again, because I used the wrong issue number in the commit (should be 1045 instead of 1023) 😕 |
No description provided.