-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#811] Case notification base code #435
Merged
Merged
+2,800
−226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2cd4935
to
ec7e747
Compare
1684f73
to
899abd6
Compare
Codecov Report
@@ Coverage Diff @@
## develop #435 +/- ##
===========================================
+ Coverage 96.32% 96.50% +0.18%
===========================================
Files 472 482 +10
Lines 15747 16330 +583
===========================================
+ Hits 15168 15760 +592
+ Misses 579 570 -9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
vaszig
reviewed
Jan 25, 2023
…o fix dependency issue
a8d3233
to
977243a
Compare
vaszig
approved these changes
Jan 25, 2023
Okay, lets give this a try on the testenvironment due to the dependancy on OpenZaak/OpenNotificaties |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's review this part before I gets out of hand:
This is everything to accept notifications from Openzaak, including filtering the case/status/role/users, up to actually sending the message.
So these are basically two parts: the generic ZGW notification webhook and the first of the OIP specific part, but the PR touches a bunch of unrelated things because I updated the TimelineLog system-action wrapper.
I have a branch on top of this that adds the ZaakTypeConfig (to also handle eSuite's' informeren) and sending the actual email.
(not a lot of this would run locally so if the tests look good it's good)