Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#811] Case notification base code #435

Merged
merged 13 commits into from
Jan 27, 2023

Conversation

Bartvaderkin
Copy link
Contributor

@Bartvaderkin Bartvaderkin commented Jan 24, 2023

Let's review this part before I gets out of hand:

This is everything to accept notifications from Openzaak, including filtering the case/status/role/users, up to actually sending the message.

So these are basically two parts: the generic ZGW notification webhook and the first of the OIP specific part, but the PR touches a bunch of unrelated things because I updated the TimelineLog system-action wrapper.

I have a branch on top of this that adds the ZaakTypeConfig (to also handle eSuite's' informeren) and sending the actual email.

(not a lot of this would run locally so if the tests look good it's good)

@Bartvaderkin Bartvaderkin changed the title Feature/811 case notification base [#811] Case notification base code Jan 24, 2023
@Bartvaderkin Bartvaderkin force-pushed the feature/811-case-notification-base branch from 2cd4935 to ec7e747 Compare January 24, 2023 08:54
@Bartvaderkin Bartvaderkin force-pushed the feature/811-case-notification-base branch 2 times, most recently from 1684f73 to 899abd6 Compare January 24, 2023 11:57
@codecov-commenter
Copy link

Codecov Report

Merging #435 (a8d3233) into develop (74d1813) will increase coverage by 0.18%.
The diff coverage is 97.79%.

@@             Coverage Diff             @@
##           develop     #435      +/-   ##
===========================================
+ Coverage    96.32%   96.50%   +0.18%     
===========================================
  Files          472      482      +10     
  Lines        15747    16330     +583     
===========================================
+ Hits         15168    15760     +592     
+ Misses         579      570       -9     
Impacted Files Coverage Δ
src/open_inwoner/urls.py 87.50% <ø> (ø)
src/open_inwoner/openzaak/cases.py 76.00% <50.00%> (+5.33%) ⬆️
src/open_inwoner/openzaak/notifications.py 92.70% <92.70%> (ø)
src/open_inwoner/openzaak/auth.py 94.11% <94.11%> (ø)
src/open_inwoner/utils/tests/helpers.py 95.00% <95.00%> (ø)
src/open_inwoner/openzaak/api/views.py 97.95% <97.95%> (ø)
...nwoner/openzaak/tests/test_notification_handler.py 99.37% <99.37%> (ø)
src/open_inwoner/accounts/query.py 100.00% <100.00%> (ø)
src/open_inwoner/accounts/tests/test_logging.py 100.00% <100.00%> (ø)
...c/open_inwoner/accounts/tests/test_user_manager.py 100.00% <100.00%> (ø)
... and 26 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Bartvaderkin Bartvaderkin marked this pull request as ready for review January 24, 2023 13:25
@Bartvaderkin Bartvaderkin requested a review from vaszig January 24, 2023 15:49
@Bartvaderkin Bartvaderkin force-pushed the feature/811-case-notification-base branch from a8d3233 to 977243a Compare January 25, 2023 10:56
@alextreme
Copy link
Member

Okay, lets give this a try on the testenvironment due to the dependancy on OpenZaak/OpenNotificaties

@alextreme alextreme merged commit 0fbf948 into develop Jan 27, 2023
@alextreme alextreme deleted the feature/811-case-notification-base branch January 27, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants