[#801] Fix/close menus with escape button

[vaszig]

No description provided.

[Bartvaderkin]

@vaszig I think this has been covered by Sven's solution for some other issues like the focus handling (the menu is now a )

[vaszig]

@Bartvaderkin thanks for letting me know. I will double check this as soon as Svenv's PRs are merged.

[alextreme]

@vaszig can be checked, Svens PR was merged afaik

[alextreme]

Discussed: This is for being able to close (for instance) the dropdown menu in Mijn Profiel with an escape-button

[jiromaykin]

@vaszig This seems to work well (and it doesn't even have the Header click-trap problem) but when I check out this branch the dropdown seems to be styled differently now (extra borders in different places)?
(Edit): It seems its inherited the border-width of the "button--secondary " style rule.

.button--secondary { background-color: var(--color-secondary); border: 1px solid var(--color-secondary); [.....]

[vaszig]

It's an old branch so the borders are not updated here.
It works because it only implements what we wanted..the escape key. Svenv's approach is more generic and affects a lot of code, that's why we have the problem.

[jiromaykin]

It's an old branch so the borders are not updated here.

Sorry @vaszig yes, I see now - I would think this PR might be closed/reviewed, once #466 (escape-button combo with focus-trap on header/search) is reviewed and merged?

[vaszig]

Sorry @vaszig yes, I see now - I would think this PR might no longer be needed, once #466 (escape-button combo with focus-trap on header/search) is reviewed and merged?

Yes indeed, we can close this PR as soon as we merge 466. We can handle the dropdowns (task 1078 in taiga) in a separate PR.

[codecov-commenter]

Codecov Report

Merging #417 (2018977) into develop (9e8c1bd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #417   +/-   ##
========================================
  Coverage    96.46%   96.46%           
========================================
  Files          505      505           
  Lines        18255    18255           
========================================
  Hits         17609    17609           
  Misses         646      646           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[jiromaykin]

The Dropdown JS we still need; the PrimaryNavigation might not be necessary anymore after all of the updates from PR #466