[#911] Added 'indicatieInternOfExtern' access check, also refactored cases-views tests #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #394 +/- ##
========================================
Coverage 96.10% 96.10%
========================================
Files 462 462
Lines 15056 15082 +26
========================================
+ Hits 14469 14494 +25
- Misses 587 588 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Bartvaderkin
force-pushed
the
fix/991-internal-case-leaks
branch
from
74d0935 to
7cac73a
Compare
…cases-views tests Refactoring tests was about casing issue in generate_oas_component() mocks, using setUpTestData(), ClearCachesMixin and use of URLs instead of links
Bartvaderkin
force-pushed
the
fix/991-internal-case-leaks
branch
from
7cac73a to
c9888fe
Compare
vaszig
approved these changes
Dec 19, 2022
| # resolve case-type | ||
| self.case.zaaktype = fetch_single_case_type(self.case.zaaktype) | ||
| if not self.case.zaaktype: | ||
| return self.handle_no_permission() |
There was a problem hiding this comment.
I don't know if this is done for readability purposes but we have five times the same return statement.
There was a problem hiding this comment.
Yep, to keep the decision procedure more readable (without adding extra noisy workarounds) it just returns after every failed condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: the important change was to
is_zaak_visible()Then I found this wasn't applied to the list-views at all, and that required a refactor because we needed the filtering before the pagination which required to move the zaaktype retrieval code around.
But then I found the issue with the property casing in the mocks, and some other test noise like the cache-reset mixin and test data setup.
As a bonus: less noisy UserFactory, and improved ZGW api_model dataclass annotations that support swapping link URI's to objects because that is how it was used.