-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#927] Added cache decorator to some case-views to improve navigation #380
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #380 +/- ##
===========================================
+ Coverage 95.92% 96.05% +0.12%
===========================================
Files 457 461 +4
Lines 14471 14842 +371
===========================================
+ Hits 13881 14256 +375
+ Misses 590 586 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it would be good to make these durations into Django settings?
I'm doubting the zaak/informatieobject caching, it might be viable for ~30 seconds but 3 minutes feels a bit too long. And with 30 seconds it might just not be worthwhile anymore.
Feel free to discuss this with Anna if you want. Could also be something that we enable after the demo.
… calls only used in document-download view
@alextreme I appended the PR with settings for the timeouts and removed caching on two calls that currently don't need it because they are only used in the download view. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For fetch_specific_status
function (openzaak/cases) we don't use a variable because it's only used once right?
No description provided.