Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated django-open-forms-client for slightly less noise and errors during startup/CI/manage.py #353

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

Bartvaderkin
Copy link
Contributor

There was some open-forms related code at module-level that tries to grab some data to fill some choices but it fails if the credentials aren't set, like on a fresh database.

@Bartvaderkin Bartvaderkin marked this pull request as ready for review November 30, 2022 14:27
@codecov-commenter
Copy link

Codecov Report

Merging #353 (9b6467c) into develop (ba8d3c8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #353   +/-   ##
========================================
  Coverage    96.34%   96.34%           
========================================
  Files          438      438           
  Lines        13699    13699           
========================================
  Hits         13198    13198           
  Misses         501      501           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alextreme alextreme merged commit 348165a into develop Nov 30, 2022
@alextreme alextreme deleted the fix/upgrade-django-open-forms-client branch November 30, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants