Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#909] Added FAQ to Product page #350

Merged
merged 3 commits into from
Nov 30, 2022
Merged

Conversation

Bartvaderkin
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2022

Codecov Report

Merging #350 (26f78bf) into develop (e2db8ed) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #350      +/-   ##
===========================================
- Coverage    96.43%   96.39%   -0.05%     
===========================================
  Files          433      441       +8     
  Lines        13287    13775     +488     
===========================================
+ Hits         12813    13278     +465     
- Misses         474      497      +23     
Impacted Files Coverage Δ
src/open_inwoner/utils/context_processors.py 90.90% <ø> (ø)
src/open_inwoner/pdc/admin/faq.py 100.00% <100.00%> (ø)
src/open_inwoner/pdc/admin/product.py 97.43% <100.00%> (+0.03%) ⬆️
src/open_inwoner/pdc/managers.py 87.50% <100.00%> (+4.16%) ⬆️
...en_inwoner/pdc/migrations/0043_question_product.py 100.00% <100.00%> (ø)
...grations/0044_question_category_or_product_null.py 100.00% <100.00%> (ø)
src/open_inwoner/pdc/models/faq.py 96.00% <100.00%> (+3.14%) ⬆️
src/open_inwoner/pdc/tests/factories.py 100.00% <100.00%> (ø)
src/open_inwoner/pdc/tests/test_faq.py 100.00% <100.00%> (ø)
src/open_inwoner/pdc/tests/test_product.py 100.00% <100.00%> (ø)
... and 29 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Bartvaderkin Bartvaderkin marked this pull request as ready for review November 30, 2022 08:55
Copy link
Contributor

@vaszig vaszig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks nice to me. The only thing, which I don't know if we want to add, is to protect the addition of both category and product generally and not only via a form (as you have already done in the clean method).

@Bartvaderkin
Copy link
Contributor Author

Bartvaderkin commented Nov 30, 2022

@vaszig Good point. I'll try to add Have added a commit with a CheckConstraint so it can't save even if something bypasses the clean().

Copy link
Contributor

@annashamray annashamray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice! 👍

@alextreme alextreme merged commit f5d1769 into develop Nov 30, 2022
@alextreme alextreme deleted the feature/909-product-faq branch November 30, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants