✨ - Use htmx to async update messages. #342

svenvandescheur · 2022-11-21T14:58:22Z

No description provided.

annashamray · 2022-11-21T16:45:44Z

Is it possible to unit test? (if not then should we really use it?)

svenvandescheur · 2022-11-21T19:12:36Z

Is it possible to unit test? (if not then should we really use it?)

It uses the same logic as the previous implementation except async. The actual implementation is iirc 4 properties, testing those would just be retesting the htmx library.

annashamray · 2022-11-22T09:48:52Z

I still think this should be tested. If unit testing is not a good idea, end-to-end tests could be introduced

svenvandescheur · 2022-11-22T09:55:24Z

I still think this should be tested. If unit testing is not a good idea, end-to-end tests could be introduced

Ok, let's see if I can add some webtest to test the integration.

codecov-commenter · 2022-11-23T09:36:01Z

Codecov Report

Merging #342 (cd4a1d3) into develop (de5a4fe) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #342      +/-   ##
===========================================
+ Coverage    96.41%   96.45%   +0.03%     
===========================================
  Files          433      433              
  Lines        13140    13354     +214     
===========================================
+ Hits         12669    12880     +211     
- Misses         471      474       +3

Impacted Files	Coverage Δ
.../open_inwoner/components/templatetags/form_tags.py	`95.12% <ø> (ø)`
src/open_inwoner/accounts/tests/test_inbox_page.py	`100.00% <100.00%> (ø)`
src/open_inwoner/components/tests/test_messages.py	`100.00% <100.00%> (ø)`
src/open_inwoner/openzaak/cases.py	`67.85% <0.00%> (-4.53%)`	⬇️
src/open_inwoner/openzaak/utils.py	`92.59% <0.00%> (-2.41%)`	⬇️
src/open_inwoner/openzaak/tests/test_cases.py	`100.00% <0.00%> (ø)`
.../open_inwoner/components/templatetags/card_tags.py	`96.96% <0.00%> (ø)`
.../open_inwoner/components/templatetags/list_tags.py	`100.00% <0.00%> (ø)`
src/open_inwoner/accounts/views/cases.py	`99.30% <0.00%> (+0.04%)`	⬆️
src/open_inwoner/utils/templatetags/utils.py	`62.50% <0.00%> (+3.04%)`	⬆️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

svenvandescheur · 2022-11-23T11:00:38Z

@annashamray I've added a selenium test for this.

alextreme

Does seem like a bit of HTML magic, but lets try this out.

@annashamray see if you can help Sven with the requirements FIXME for adding selenium

annashamray · 2022-11-25T09:38:56Z

@alextreme dependencies didn't compile because there was a version conflict between our certifi and selenium certifi. I updated our version and it seems to work

alextreme · 2022-11-25T10:03:30Z

Great thanks @annashamray !

.github/workflows/code-quality.yml

annashamray · 2022-11-25T10:00:16Z

src/open_inwoner/components/templates/components/Form/Form.html

@@ -9,6 +9,12 @@
    {% if data_confirm_title %}data-confirm-title="{{ data_confirm_title }}"{% endif %}
    {% if data_confirm_cancel %}data-confirm-cancel="{{ data_confirm_cancel }}"{% endif %}
    {% if data_confirm_default %}data-confirm-default="{{ data_confirm_default }}"{% endif %}
+    {% if async_selector %}
+        hx-{{ method|lower }}="{{ action|default:"./" }}"


action variable is not documented in template tags

action is not documented again

src/open_inwoner/components/templates/components/Form/Form.html

src/open_inwoner/accounts/tests/test_inbox_page.py

alextreme

Can be merged after Anna's approval

annashamray

Polling doesn't work on my local machine. Does it work for you?

src/open_inwoner/components/templates/components/Messages/Messages.html

src/open_inwoner/components/templatetags/form_tags.py

src/open_inwoner/components/templates/components/Messages/Messages.html

svenvandescheur · 2022-11-28T13:29:31Z

Polling doesn't work on my local machine. Does it work for you?

yes

annashamray

I have one remark about documentation which is not resolved

Polling still doesn't work for me, but maybe the problem is in my config, so I'll approve after the template variable is documented

annashamray · 2022-11-28T14:23:24Z

src/open_inwoner/components/templates/components/Form/Form.html

@@ -9,6 +9,12 @@
    {% if data_confirm_title %}data-confirm-title="{{ data_confirm_title }}"{% endif %}
    {% if data_confirm_cancel %}data-confirm-cancel="{{ data_confirm_cancel }}"{% endif %}
    {% if data_confirm_default %}data-confirm-default="{{ data_confirm_default }}"{% endif %}
+    {% if async_selector %}
+        hx-{{ method|lower }}="{{ action|default:"./" }}"


action is not documented again

annashamray · 2022-11-28T14:30:56Z

@Bartvaderkin @svenvandescheur
Polling works on your local machine right? How do you test it?

My steps:

log in as use A, go to "Mijn berichten" page with user B
in other session hijack user B, go to "Mijn berichten" and send message to user A
Wait for this message to appear in the user A session
The message doesn't appear

svenvandescheur · 2022-11-28T14:57:13Z

@Bartvaderkin @svenvandescheur Polling works on your local machine right? How do you test it?

My steps:

log in as use A, go to "Mijn berichten" page with user B

in other session hijack user B, go to "Mijn berichten" and send message to user A

Wait for this message to appear in the user A session
The message doesn't appear

I made screencapture:

annashamray · 2022-11-28T15:24:34Z

Thanks! I'll test it on our test env after deployment and will try to understand why it doesn't work locally for me

✨ - Use htmx to async update messages.

7fd80de

svenvandescheur requested a review from alextreme November 21, 2022 14:58

svenvandescheur requested a review from annashamray November 22, 2022 09:53

svenvandescheur added 4 commits November 22, 2022 18:19

✅ - Add test for async_selector in messages.

db8b272

👕 - Black.

656db68

⬆️ - Selenium.

2a180ab

💚 - Make selenium/Firefox run headless.

4e908cb

svenvandescheur added 4 commits November 23, 2022 10:56

👕 - isort

a290762

💚 - Attempt to fix the build.

a360f8e

✅ Uncomment commented out test.

8233546

👕 - prettier

7bef0e4

alextreme approved these changes Nov 23, 2022

View reviewed changes

annashamray requested a review from Bartvaderkin November 25, 2022 09:20

➕ bump certifi and add selenium

dadb55b

annashamray requested changes Nov 25, 2022

View reviewed changes

svenvandescheur added 5 commits November 25, 2022 15:20

👌 - action variable is not documented in template tags.

b9be15e

👌 - Should we also add polling for messages?

4f8073b

👌 - Why to use this tag? I commented it and nothing changed.

6589347

👌 - Nice! Perhaps in the future we can also test it for Chrome

919567e

👕 - Black and isort.

cd4a1d3

svenvandescheur requested review from annashamray and alextreme November 25, 2022 16:46

alextreme approved these changes Nov 25, 2022

View reviewed changes

annashamray requested changes Nov 28, 2022

View reviewed changes

svenvandescheur added 4 commits November 28, 2022 11:48

👌 - Should we make it 5 seconds?

2f86b51

🐛 - Fix bug in accessibility code.

fff0694

:memo - Fix documentation.

138e2c0

👌 - Please add test for polling.

0e34b07

svenvandescheur requested a review from annashamray November 28, 2022 12:55

:shirt - black

7185ea7

Bartvaderkin approved these changes Nov 28, 2022

View reviewed changes

annashamray requested changes Nov 28, 2022

View reviewed changes

🐛 - Fix incorrect argument name.

bb1c0ff

svenvandescheur requested a review from annashamray November 28, 2022 14:58

annashamray approved these changes Nov 28, 2022

View reviewed changes

svenvandescheur merged commit 25afe67 into develop Nov 28, 2022

svenvandescheur deleted the htmx branch November 28, 2022 15:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ - Use htmx to async update messages. #342

✨ - Use htmx to async update messages. #342

svenvandescheur commented Nov 21, 2022

annashamray commented Nov 21, 2022

svenvandescheur commented Nov 21, 2022

annashamray commented Nov 22, 2022

svenvandescheur commented Nov 22, 2022 •

edited

Loading

codecov-commenter commented Nov 23, 2022 •

edited

Loading

svenvandescheur commented Nov 23, 2022 •

edited

Loading

alextreme left a comment

annashamray commented Nov 25, 2022

alextreme commented Nov 25, 2022

annashamray Nov 25, 2022

annashamray Nov 28, 2022

alextreme left a comment

annashamray left a comment

svenvandescheur commented Nov 28, 2022

annashamray left a comment

annashamray Nov 28, 2022

annashamray commented Nov 28, 2022

svenvandescheur commented Nov 28, 2022

annashamray commented Nov 28, 2022

✨ - Use htmx to async update messages. #342

✨ - Use htmx to async update messages. #342

Conversation

svenvandescheur commented Nov 21, 2022

annashamray commented Nov 21, 2022

svenvandescheur commented Nov 21, 2022

annashamray commented Nov 22, 2022

svenvandescheur commented Nov 22, 2022 • edited Loading

codecov-commenter commented Nov 23, 2022 • edited Loading

Codecov Report

svenvandescheur commented Nov 23, 2022 • edited Loading

alextreme left a comment

Choose a reason for hiding this comment

annashamray commented Nov 25, 2022

alextreme commented Nov 25, 2022

annashamray Nov 25, 2022

Choose a reason for hiding this comment

annashamray Nov 28, 2022

Choose a reason for hiding this comment

alextreme left a comment

Choose a reason for hiding this comment

annashamray left a comment

Choose a reason for hiding this comment

svenvandescheur commented Nov 28, 2022

annashamray left a comment

Choose a reason for hiding this comment

annashamray Nov 28, 2022

Choose a reason for hiding this comment

annashamray commented Nov 28, 2022

svenvandescheur commented Nov 28, 2022

annashamray commented Nov 28, 2022

svenvandescheur commented Nov 22, 2022 •

edited

Loading

codecov-commenter commented Nov 23, 2022 •

edited

Loading

svenvandescheur commented Nov 23, 2022 •

edited

Loading