-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#889] Optimize cases listview #336
[#889] Optimize cases listview #336
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #336 +/- ##
===========================================
+ Coverage 96.41% 96.43% +0.01%
===========================================
Files 433 433
Lines 13131 13278 +147
===========================================
+ Hits 12660 12804 +144
- Misses 471 474 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
26dd5fc
to
56b2b2b
Compare
Nice cache function with the custom key. One generic feedback I have left is maybe we should move the cached cases retrieval code in a function or a method because it is growing and taking over the get_context_data() method a bit. |
As discussed during our meeting I am going to update the code according to Bart's comments and I will add some explanation to the cache decorator as well. So, I am sorry Anna but I will need some more time before being able to merge this! |
302efb8
to
9efb177
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice and neat!
🙈 |
Further optimization can be done when we solve the problem with parallel requests in tests.