[#2920] Fix check for natural key duplicates in ZGW imports #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The check for natural keys duplicates produced false positives
because the same `omschrijving` can be used for different types
of ZGW objects (e.g. "Afgehandel" for status and resulaat).
The check for duplicate natural keys is now scoped to the type
of ZGW configuration.
pi-sigma
force-pushed
the
issue/2920-zgw-import-export-dupes
branch
from
e2f1391 to
bced8cd
Compare
swrichards
approved these changes
Dec 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1515 +/- ##
========================================
Coverage 94.25% 94.25%
========================================
Files 1068 1068
Lines 40457 40460 +3
========================================
+ Hits 38133 38136 +3
Misses 2324 2324 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check for natural keys duplicates produced false positives because the same
omschrijvingcan be used for different types of ZGW objects (e.g. "Afgehandeld" for status and resultaat). The check for duplicate natural keys is now scoped to the type of ZGW configuration.Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/issue/2920