[#2757] Add home view styling for registratiemelding notifications #1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiromaykin
changed the title
jiromaykin
force-pushed
the
fix/2757-homepage-notification
branch
from
78de6b1 to
36e942b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1491 +/- ##
========================================
Coverage 94.29% 94.29%
========================================
Files 1066 1066
Lines 40157 40157
========================================
Hits 37866 37866
Misses 2291 2291 ☔ View full report in Codecov by Sentry. |
jiromaykin
force-pushed
the
fix/2757-homepage-notification
branch
from
5e62119 to
904afd4
Compare
jiromaykin
force-pushed
the
fix/2757-homepage-notification
branch
from
904afd4 to
6a84ca8
Compare
pi-sigma
approved these changes
Nov 14, 2024
|
Piet approves |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
userstory: https://taiga.maykinmedia.nl/project/open-inwoner/us/2475
Figma design: https://www.figma.com/design/iKGhWhstaLIlFSaND2q7cE/OIP---Designs-(new)?t=h3bwJSSWV49cLKFB-0
Testing:
Login and go to URL http://localhost:8000/accounts/register/ to see Notification
IF notification exists, margins and padding will change on Home page only: so the Welcome message drops lower and becomes readable again, also there is a difference between the margins on mobile and desktop:
When the user closes the notification,
styling should jump back to normal.