Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2852] Integrate OpenKlant2 service with list view #1483

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

pi-sigma
Copy link
Contributor

@pi-sigma pi-sigma commented Nov 1, 2024

@pi-sigma pi-sigma changed the title Integrate OpenKlant2 service with list view [#2852] Integrate OpenKlant2 service with list view Nov 5, 2024
@pi-sigma pi-sigma force-pushed the task/2852-openklant2-esuite-list branch 3 times, most recently from a12791c to c20cb1a Compare November 6, 2024 13:34
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 84.53608% with 15 lines in your changes missing coverage. Please review.

Project coverage is 94.28%. Comparing base (39f1cf8) to head (4faf2f2).

Files with missing lines Patch % Lines
src/open_inwoner/openklant/services.py 60.00% 14 Missing ⚠️
src/open_inwoner/openklant/tests/test_views.py 97.36% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1483      +/-   ##
===========================================
- Coverage    94.31%   94.28%   -0.03%     
===========================================
  Files         1066     1066              
  Lines        40063    40118      +55     
===========================================
+ Hits         37785    37825      +40     
- Misses        2278     2293      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi-sigma pi-sigma marked this pull request as ready for review November 6, 2024 14:05
@pi-sigma pi-sigma requested a review from swrichards November 6, 2024 14:05
Copy link
Collaborator

@swrichards swrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good work, only small things really.

src/open_inwoner/openklant/constants.py Outdated Show resolved Hide resolved
src/open_inwoner/openklant/services.py Show resolved Hide resolved
src/openklant2/_resources/base.py Outdated Show resolved Hide resolved
src/openklant2/_resources/partij.py Outdated Show resolved Hide resolved
src/open_inwoner/openklant/services.py Show resolved Hide resolved
src/open_inwoner/openklant/services.py Outdated Show resolved Hide resolved
src/open_inwoner/openklant/services.py Outdated Show resolved Hide resolved
@pi-sigma pi-sigma force-pushed the task/2852-openklant2-esuite-list branch 6 times, most recently from 6d63690 to fb9aa50 Compare November 8, 2024 12:39
@pi-sigma pi-sigma force-pushed the task/2852-openklant2-esuite-list branch from fb9aa50 to 4faf2f2 Compare November 8, 2024 13:07
@pi-sigma pi-sigma requested a review from swrichards November 8, 2024 13:28
@swrichards swrichards requested a review from alextreme November 8, 2024 17:10
@alextreme alextreme merged commit 35ae098 into develop Nov 8, 2024
20 checks passed
@alextreme alextreme deleted the task/2852-openklant2-esuite-list branch November 8, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants