-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♿ [#2623] A11y Fix and add SpeechSynthesis pause/stop functionality #1460
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1460 +/- ##
========================================
Coverage 94.59% 94.59%
========================================
Files 1063 1063
Lines 39681 39681
========================================
Hits 37537 37537
Misses 2144 2144 ☔ View full report in Codecov by Sentry. |
56d9dd7
to
ae12702
Compare
7932320
to
904fd1d
Compare
@pi-sigma @swrichards Please use headphones when testing this! 😄🎧 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed on Slack: this does not seem to work on my machine, so I couldn't test this locally. @jiromaykin is looking into whether it really is a Linux thing, or a more limited set of issues. Re-request the review once we know and we'll see if there's any further changes at this point.
@pi-sigma and @swrichards : These things need to work:
|
We can ignore the Firefox+Linux combination for this feature, if it works for Win+Mac that is sufficient for the time being in my eyes |
…hsynthesis ♿ [#2623] A11y Fix and add SpeechSynthesis pause/stop functionality
Issue: https://taiga.maykinmedia.nl/project/open-inwoner/task/2623
Turns out: the Pause code was in place since the beginning but wrongly implemented since there was no data-attribute,
I also added a stop function on reload because it doesn't make sense to keep on reading a page you're no longer looking at.