Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♿ [#2623] A11y Fix and add SpeechSynthesis pause/stop functionality #1460

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

jiromaykin
Copy link
Contributor

@jiromaykin jiromaykin commented Oct 22, 2024

Issue: https://taiga.maykinmedia.nl/project/open-inwoner/task/2623

Turns out: the Pause code was in place since the beginning but wrongly implemented since there was no data-attribute,
I also added a stop function on reload because it doesn't make sense to keep on reading a page you're no longer looking at.

Speech-toggle-aria-title

@jiromaykin jiromaykin changed the title ♿ [#2623] Fix and add SpeechSynthesis pause/stop functionality ♿ [#2623] A11y Fix and add SpeechSynthesis pause/stop functionality Oct 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.59%. Comparing base (5391b5f) to head (904fd1d).
Report is 16 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1460   +/-   ##
========================================
  Coverage    94.59%   94.59%           
========================================
  Files         1063     1063           
  Lines        39681    39681           
========================================
  Hits         37537    37537           
  Misses        2144     2144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiromaykin jiromaykin force-pushed the issue/2623-A11y-pause-speechsynthesis branch from 56d9dd7 to ae12702 Compare October 22, 2024 16:55
@jiromaykin jiromaykin force-pushed the issue/2623-A11y-pause-speechsynthesis branch from 7932320 to 904fd1d Compare October 24, 2024 08:15
@jiromaykin jiromaykin marked this pull request as ready for review October 24, 2024 08:15
@jiromaykin
Copy link
Contributor Author

@pi-sigma @swrichards Please use headphones when testing this! 😄🎧
Also: keep npm run watch running and make sure to thoroughly cache-refresh your browser.

Copy link
Collaborator

@swrichards swrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on Slack: this does not seem to work on my machine, so I couldn't test this locally. @jiromaykin is looking into whether it really is a Linux thing, or a more limited set of issues. Re-request the review once we know and we'll see if there's any further changes at this point.

@jiromaykin
Copy link
Contributor Author

As discussed on Slack: this does not seem to work on my machine, so I couldn't test this locally. @jiromaykin is looking into whether it really is a Linux thing, or a more limited set of issues. Re-request the review once we know and we'll see if there's any further changes at this point.

@pi-sigma and @swrichards :
This has to be a Linux issue. It works properly in all browsers on Browserstack. So first see if you can run this properly on Linux inside the official Chrome version from Google itself - since @alextreme claimed it is working there.

These things need to work:

  1. 1st click on ‘Lees voor’ the speech should start
  2. then the ‘Lees voor’ button also visibly toggles to ‘pauzeer’
  3. the aria-label and title attributes of the link also toggle,
  4. the second time clicking the Pauzeer button should pause the Speech Voice and change the link back to ‘Lees voor’ and also toggles all other attributes back
  5. after which you can continue and click ‘Lees voor’ again, so Speech should continue where you left off, and visually looks like 'Pauzeer' again
  6. +page reload, or click on another link: stops speech completely

@alextreme
Copy link
Member

We can ignore the Firefox+Linux combination for this feature, if it works for Win+Mac that is sufficient for the time being in my eyes

@alextreme alextreme merged commit 5aba3cc into develop Nov 4, 2024
20 checks passed
@alextreme alextreme deleted the issue/2623-A11y-pause-speechsynthesis branch November 4, 2024 15:01
pi-sigma pushed a commit that referenced this pull request Nov 6, 2024
…hsynthesis

♿ [#2623] A11y Fix and add SpeechSynthesis pause/stop functionality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants