Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2577] Use CKEditorWidget for SSD help-text fields #1274

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

pi-sigma
Copy link
Contributor

@pi-sigma pi-sigma changed the title Transform SSD help-text field into HTML editor field [#2577] Transform SSD help-text field into HTML editor field Jun 24, 2024
@pi-sigma pi-sigma force-pushed the task/2577-ssd-help-text branch from 10706bf to 558058d Compare June 24, 2024 14:13
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.24%. Comparing base (1d83a79) to head (80e830c).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1274      +/-   ##
===========================================
+ Coverage    44.23%   44.24%   +0.01%     
===========================================
  Files          973      973              
  Lines        35602    35610       +8     
===========================================
+ Hits         15747    15755       +8     
  Misses       19855    19855              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi-sigma pi-sigma force-pushed the task/2577-ssd-help-text branch from 558058d to c6b8ad4 Compare June 25, 2024 12:14
@pi-sigma pi-sigma marked this pull request as ready for review June 26, 2024 08:41
@pi-sigma
Copy link
Contributor Author

We also need to decide which formatting options we want to support, hence the update to CKEDITOR_CONFIGS in the settings. I made a stab at what seems like a reasonalbe default to me; let me know if this is too much or not enough.

src/open_inwoner/conf/base.py Outdated Show resolved Hide resolved
src/open_inwoner/conf/base.py Outdated Show resolved Hide resolved
@pi-sigma pi-sigma marked this pull request as draft July 1, 2024 10:48
@pi-sigma pi-sigma force-pushed the task/2577-ssd-help-text branch from c6b8ad4 to 8f43c29 Compare July 1, 2024 12:07
@pi-sigma pi-sigma changed the title [#2577] Transform SSD help-text field into HTML editor field [#2577] Use CKEditorWidget for SSD help-text fields Jul 1, 2024
@pi-sigma pi-sigma force-pushed the task/2577-ssd-help-text branch 2 times, most recently from 57cec9f to 74c7de4 Compare July 1, 2024 13:40
@pi-sigma pi-sigma requested review from swrichards and jiromaykin July 1, 2024 14:47
Copy link
Contributor

@jiromaykin jiromaykin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor style addition needed + I am quite happy users can still add headings... They cannot add an H1 anyway currently, so no problem for accessibility.

@pi-sigma pi-sigma force-pushed the task/2577-ssd-help-text branch from 74c7de4 to 80e830c Compare July 3, 2024 08:20
@pi-sigma pi-sigma marked this pull request as ready for review July 3, 2024 09:01
@pi-sigma pi-sigma requested a review from jiromaykin July 3, 2024 09:01
@alextreme alextreme merged commit 8f65345 into develop Jul 9, 2024
17 checks passed
@alextreme alextreme deleted the task/2577-ssd-help-text branch July 9, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants