-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/export pdf #119
Feature/export pdf #119
Conversation
8bcde2f
to
9d1eafd
Compare
@@ -68,7 +68,8 @@ | |||
|
|||
&__item { | |||
padding: var(--spacing-medium); | |||
border-bottom: 1px solid var(--color-gray-light); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I separated it into two properties for weasyprint to be able to process it
9d1eafd
to
b00e6fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double-check a couple of aspects but nearly there!
In the design there is an Should I remove these buttons and replace them with one button to export the list of action? |
No you can leave the individual buttons in, this was indeed as designed. So simply adding an option to export all actions in one PDF is sufficient (and as mentioned this can also be split off into a separate task, up to you what you prefer) |
Happy with the state as-is, feel free to merge and to create separate tasks for the other remarks where necessary |
Note:
weasyprint
can't process grid tags (open issue - Kozea/WeasyPrint#543), and no design for pdf documents was provided, so I made it very simple and table based