Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 [#2194] Correct use of Sections and other gaps #1161

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

jiromaykin
Copy link
Contributor

@jiromaykin jiromaykin commented Apr 16, 2024

This PR solves wrong section styles and some other faulty gaps/margins/paddings here and there.
issue: https://taiga.maykinmedia.nl/project/open-inwoner/issue/2194

the main issue is a bit of a 'blame' because some styles were put inside 'contactmomenten' that did not belong there + all Section tags in the entire project were styled wrong because of the CSS that was targeting all Section Tags instead of a .[componentname]-section class (we need to target components instead of everything everywhere all at once 🙂)

inside scope of this issue:

  • remove margins from section tags, check to see if section styling doesn't break everywhere

outside scope of this issue so did is as an extra

  • delete pagination styling from wrong file - move to .pagination component and remove table display
  • improve card spacing for Userfeed and other Cards
  • remove unnecessary margin on Mijn Aanvragen page

@@ -99,15 +98,3 @@
padding: var(--spacing-medium) 0 0 0;
}
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this code presented the original issue of wrongly styled sections.

@jiromaykin jiromaykin marked this pull request as ready for review April 16, 2024 10:21
@jiromaykin jiromaykin requested a review from pi-sigma April 16, 2024 10:59
@alextreme alextreme merged commit 62ca15a into develop Apr 18, 2024
15 checks passed
@alextreme alextreme deleted the fix/2194-section-styles branch April 18, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants