✨ [#2306] Move newsletter form to profile detail page #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1148 +/- ##
===========================================
- Coverage 95.08% 95.07% -0.01%
===========================================
Files 948 948
Lines 33547 33542 -5
===========================================
- Hits 31897 31891 -6
- Misses 1650 1651 +1 ☔ View full report in Codecov by Sentry. |
jiromaykin
approved these changes
Apr 9, 2024
| <div class="tabled__section"> | ||
| <h2 class="h2 title" id="newsletters">{% trans "Nieuwsbrieven" %}</h2> | ||
| </div> | ||
| <form method="POST" id="newsletter-form" class="form" novalidate> |
There was a problem hiding this comment.
The top-padding for forms inside a tabled section is too big here but I can change that in an upcoming PR.
Bartvaderkin
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
I approve it for now but I note it slowly gets a bit messy to handle multiple forms on the same view, as the standard formview handlers on the view now get mixed use.
The newsletter now claims the form_valid() while there is already an ad-hoc Plans-post-thing going on and who knows what in the future.
stevenbal
force-pushed
the
feature/2306-move-newsletters-form-to-mijn-profiel
branch
from
c435aed to
c54ac68
Compare
alextreme
deleted the
feature/2306-move-newsletters-form-to-mijn-profiel
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
task: https://taiga.maykinmedia.nl/project/open-inwoner/task/2306