🐛 [#2284] Do not show selected categories in plugin if disabled #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenbal
force-pushed
the
fix/2284-selected-categories-visible-if-disabled
branch
from
f76e545 to
18ab2f3
Compare
Bartvaderkin
approved these changes
Apr 4, 2024
Comment on lines
+126
to
+131
| if app_config := apphook_pool.get_apphook(hook_class.__name__).app_config: | ||
| # attach it to the page for convenience | ||
| if config_args is None: | ||
| config_args = dict() | ||
| config_args["namespace"] = hook_class.app_name | ||
| p.app_config = app_config.objects.get_or_create(**config_args) |
There was a problem hiding this comment.
Cooool. Didn't know about the apphook_pool. Could be something for the hacky stuff in open_inwoner/cms/utils/page_display.py
pi-sigma
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: https://taiga.maykinmedia.nl/project/open-inwoner/issue/2284