Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2187] Implemented email-verification #1126

Merged
merged 3 commits into from
Apr 11, 2024

Conversation

Bartvaderkin
Copy link
Contributor

There is a setting in the SiteConfigurations (email fieldset) to enable it.

And the verified_email field is editable for testing.

Base automatically changed from feature/2187-user-middleware2 to develop April 2, 2024 17:17
@Bartvaderkin Bartvaderkin force-pushed the feature/2187-email-verification2 branch from 40e8079 to a898f1e Compare April 5, 2024 08:54
@Bartvaderkin Bartvaderkin force-pushed the feature/2187-email-verification2 branch from a898f1e to 3438f89 Compare April 5, 2024 09:01
@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 96.52605% with 14 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (develop@6d6d519). Click here to learn what that means.
Report is 12 commits behind head on develop.

Files Patch % Lines
src/open_inwoner/mail/views.py 70.37% 8 Missing ⚠️
src/open_inwoner/accounts/views/registration.py 93.75% 2 Missing ⚠️
src/open_inwoner/mail/verification.py 96.92% 2 Missing ⚠️
src/open_inwoner/mail/tests/test_verification.py 99.51% 1 Missing ⚠️
src/open_inwoner/utils/url.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1126   +/-   ##
==========================================
  Coverage           ?   95.08%           
==========================================
  Files              ?      947           
  Lines              ?    33554           
  Branches           ?        0           
==========================================
  Hits               ?    31906           
  Misses             ?     1648           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bartvaderkin Bartvaderkin marked this pull request as ready for review April 5, 2024 09:46
Copy link
Contributor

@stevenbal stevenbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, some minor comments

src/open_inwoner/conf/parts/maileditor.py Outdated Show resolved Hide resolved
src/open_inwoner/accounts/views/registration.py Outdated Show resolved Hide resolved
src/open_inwoner/mail/verification.py Show resolved Hide resolved
src/open_inwoner/accounts/views/registration.py Outdated Show resolved Hide resolved
src/open_inwoner/mail/tests/test_verification.py Outdated Show resolved Hide resolved
src/open_inwoner/mail/verification.py Outdated Show resolved Hide resolved
src/open_inwoner/mail/tests/test_verification.py Outdated Show resolved Hide resolved
src/open_inwoner/accounts/views/registration.py Outdated Show resolved Hide resolved
@stevenbal stevenbal self-requested a review April 11, 2024 09:01
@Bartvaderkin Bartvaderkin merged commit a63f001 into develop Apr 11, 2024
15 checks passed
@Bartvaderkin Bartvaderkin deleted the feature/2187-email-verification2 branch April 11, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants