Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [#2262] Add setup configuration steps for ZGW and KIC #1116

Merged
merged 6 commits into from
Mar 29, 2024

Conversation

stevenbal
Copy link
Contributor

@stevenbal stevenbal commented Mar 25, 2024

task: https://taiga.maykinmedia.nl/project/open-inwoner/task/2262

Once django-setup-configuration supports loading YAML (see 2nd iteration maykinmedia/django-setup-configuration#1), we might want to start using that to configure the services

@stevenbal stevenbal marked this pull request as draft March 25, 2024 11:45
@stevenbal stevenbal force-pushed the feature/2262-setup-config-openzaak-openklant branch 4 times, most recently from f75ed55 to 02c40af Compare March 25, 2024 14:28
@stevenbal stevenbal changed the title Feature/2262 setup config openzaak openklant ✨ [#2262] Add setup configuration steps for ZGW and KIC Mar 25, 2024
@stevenbal stevenbal force-pushed the feature/2262-setup-config-openzaak-openklant branch 2 times, most recently from 02b63fc to 3f53c55 Compare March 25, 2024 14:58
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 87.24490% with 50 lines in your changes are missing coverage. Please review.

Project coverage is 94.92%. Comparing base (f29e0af) to head (f75ed55).

❗ Current head f75ed55 differs from pull request most recent head 3f53c55. Consider uploading reports for the commit 3f53c55 to get more accurate results

Files Patch % Lines
src/open_inwoner/configurations/bootstrap/zgw.py 70.00% 30 Missing ⚠️
src/open_inwoner/configurations/bootstrap/kic.py 78.78% 14 Missing ⚠️
src/open_inwoner/conf/base.py 89.28% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1116      +/-   ##
===========================================
- Coverage    95.01%   94.92%   -0.10%     
===========================================
  Files          913      917       +4     
  Lines        32126    32518     +392     
===========================================
+ Hits         30525    30867     +342     
- Misses        1601     1651      +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevenbal stevenbal marked this pull request as ready for review March 25, 2024 15:55
src/open_inwoner/conf/base.py Outdated Show resolved Hide resolved
src/open_inwoner/configurations/bootstrap/kic.py Outdated Show resolved Hide resolved
src/open_inwoner/conf/base.py Outdated Show resolved Hide resolved
src/open_inwoner/configurations/bootstrap/zgw.py Outdated Show resolved Hide resolved
@stevenbal stevenbal force-pushed the feature/2262-setup-config-openzaak-openklant branch from 13b75f9 to 4e934f2 Compare March 26, 2024 10:31
@stevenbal stevenbal requested a review from pi-sigma March 26, 2024 10:33
Copy link
Contributor

@Bartvaderkin Bartvaderkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty cool. Two of my comments apply to every configuration.

src/open_inwoner/configurations/bootstrap/kic.py Outdated Show resolved Hide resolved
src/open_inwoner/configurations/bootstrap/kic.py Outdated Show resolved Hide resolved
src/open_inwoner/conf/base.py Outdated Show resolved Hide resolved
@stevenbal stevenbal force-pushed the feature/2262-setup-config-openzaak-openklant branch from 4e934f2 to 4600281 Compare March 26, 2024 13:47
@stevenbal stevenbal requested a review from Bartvaderkin March 26, 2024 13:48
Copy link
Contributor

@Bartvaderkin Bartvaderkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be an interesting script that defines all these variables, and more fun debugging typos, but it is what was requested.

@stevenbal stevenbal force-pushed the feature/2262-setup-config-openzaak-openklant branch from 4600281 to 3903570 Compare March 26, 2024 14:57
@Bartvaderkin Bartvaderkin self-requested a review March 26, 2024 15:11
* prefix setup config settings
@stevenbal stevenbal force-pushed the feature/2262-setup-config-openzaak-openklant branch from 3903570 to 93b3be8 Compare March 26, 2024 15:25
@stevenbal stevenbal requested a review from Bartvaderkin March 26, 2024 15:26
Copy link
Contributor

@Bartvaderkin Bartvaderkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@stevenbal stevenbal merged commit bf6778c into develop Mar 29, 2024
17 checks passed
@stevenbal stevenbal deleted the feature/2262-setup-config-openzaak-openklant branch March 29, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants