Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🥅 [#2197] Block eHerkenning login for ZZP if RSIN is required #1108

Merged
merged 2 commits into from
Mar 22, 2024
Merged

🥅 [#2197] Block eHerkenning login for ZZP if RSIN is required #1108

merged 2 commits into from
Mar 22, 2024

Conversation

stevenbal
Copy link
Contributor

@stevenbal stevenbal commented Mar 21, 2024 •
edited
Loading

@stevenbal stevenbal marked this pull request as draft March 21, 2024 16:26
@stevenbal stevenbal force-pushed the feature/2197-block-eherkenning-for-zzp-and-openzaak branch from 9d6b492 to b61c2f6 Compare March 22, 2024 09:55
@stevenbal stevenbal requested a review from Bartvaderkin March 22, 2024 09:55
@stevenbal stevenbal marked this pull request as ready for review March 22, 2024 09:55
Bartvaderkin
Bartvaderkin approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@Bartvaderkin Bartvaderkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just optional notes

src/eherkenning/tests/test_mock_views.py Outdated Show resolved Hide resolved
src/open_inwoner/accounts/views/auth.py Show resolved Hide resolved
@stevenbal stevenbal force-pushed the feature/2197-block-eherkenning-for-zzp-and-openzaak branch from b61c2f6 to c5f3a36 Compare March 22, 2024 11:42
@stevenbal stevenbal force-pushed the feature/2197-block-eherkenning-for-zzp-and-openzaak branch from c5f3a36 to 4d1771b Compare March 22, 2024 12:54
@stevenbal stevenbal merged commit 1c0e74e into develop Mar 22, 2024
15 checks passed
@stevenbal stevenbal deleted the feature/2197-block-eherkenning-for-zzp-and-openzaak branch March 22, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bartvaderkin Bartvaderkin Bartvaderkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevenbal @Bartvaderkin