Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💄 [#1811] Fix spacing warning-header text #1101

Merged
merged 1 commit into from
Mar 20, 2024
Merged

💄 [#1811] Fix spacing warning-header text #1101

merged 1 commit into from
Mar 20, 2024

Conversation

jiromaykin
Copy link
Contributor

@jiromaykin jiromaykin marked this pull request as ready for review March 19, 2024 10:40
@jiromaykin jiromaykin changed the title 💄 [#1811] Fixed spacing warning-header text 💄 [#1811] Fix spacing warning-header text Mar 19, 2024
@jiromaykin jiromaykin requested a review from pi-sigma March 19, 2024 13:04
pi-sigma
pi-sigma requested changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@pi-sigma pi-sigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to work for me (I have npm run watch).

Screenshot from 2024-03-19 15-28-36

@jiromaykin
Copy link
Contributor Author

Doesn't seem to work for me

@pi-sigma Your screenshot looks good to me.
What doesn't work?
We still need a little bit of a top-margin for the text, or else it would look really weird if there is only one line:

oneline

@jiromaykin jiromaykin requested a review from pi-sigma March 19, 2024 16:28
pi-sigma
pi-sigma approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@pi-sigma pi-sigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the top of the icon should align perfectly with the top of the text, but the explanation makes sense; it looks weird with only one line.

@alextreme alextreme merged commit 62e7777 into develop Mar 20, 2024
15 checks passed
@alextreme alextreme deleted the fix/1811-warning-header-icon branch March 20, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi-sigma pi-sigma pi-sigma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jiromaykin @pi-sigma @alextreme