Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2234] Fix subject for questions without e-suite code mapping #1100

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

pi-sigma
Copy link
Contributor

Taiga: #2234

@pi-sigma pi-sigma force-pushed the fix/2234-contactmomenten-subject branch from 90e28eb to 6fcbb1d Compare March 19, 2024 11:33
@alextreme
Copy link
Member

Don't forget to add a regressiontest for this

@pi-sigma pi-sigma force-pushed the fix/2234-contactmomenten-subject branch from 6fcbb1d to 370edcf Compare March 19, 2024 14:59
@pi-sigma pi-sigma force-pushed the fix/2234-contactmomenten-subject branch from 370edcf to e7d0338 Compare March 19, 2024 15:14
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.00%. Comparing base (9253437) to head (370edcf).
Report is 4 commits behind head on develop.

❗ Current head 370edcf differs from pull request most recent head e7d0338. Consider uploading reports for the commit e7d0338 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1100      +/-   ##
===========================================
- Coverage    95.00%   95.00%   -0.01%     
===========================================
  Files          911      911              
  Lines        32034    32044      +10     
===========================================
+ Hits         30435    30444       +9     
- Misses        1599     1600       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi-sigma pi-sigma changed the title [#2234] Determine subject for questions without e-suite code [#2234] Fix subject for questions without e-suite code mapping Mar 20, 2024
@pi-sigma pi-sigma marked this pull request as ready for review March 20, 2024 07:37
@pi-sigma pi-sigma requested a review from stevenbal March 20, 2024 07:38
Copy link
Member

@alextreme alextreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to allow Paul to check this with the eSuite on the testenvironment

@alextreme alextreme merged commit c844fa4 into develop Mar 20, 2024
15 checks passed
@alextreme alextreme deleted the fix/2234-contactmomenten-subject branch March 20, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants