Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2217] Use 'statustekst' as default case status label #1098

Merged
merged 2 commits into from
Mar 26, 2024
Merged

[#2217] Use 'statustekst' as default case status label #1098

merged 2 commits into from
Mar 26, 2024

Conversation

pi-sigma
Copy link
Contributor

Taiga: #2217

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 95.01%. Comparing base (f29e0af) to head (3cf2051).

Files Patch % Lines
src/open_inwoner/openzaak/utils.py 50.00% 1 Missing ⚠️
src/open_inwoner/utils/translate.py 85.71% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1098      +/-   ##
===========================================
- Coverage    95.01%   95.01%   -0.01%     
===========================================
  Files          913      913              
  Lines        32126    32137      +11     
===========================================
+ Hits         30525    30535      +10     
- Misses        1601     1602       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi-sigma pi-sigma force-pushed the feature/2217-zaaktype-status-name branch from bc335ec to b7c43f4 Compare March 19, 2024 10:41
@pi-sigma pi-sigma marked this pull request as ready for review March 19, 2024 11:38
@pi-sigma pi-sigma requested a review from Bartvaderkin March 19, 2024 11:38
Bartvaderkin
Bartvaderkin suggested changes Mar 19, 2024
View reviewed changes
src/open_inwoner/cms/cases/views/status.py Outdated Show resolved Hide resolved
src/open_inwoner/cms/cases/views/status.py Outdated Show resolved Hide resolved
src/open_inwoner/openzaak/tests/test_case_detail.py Outdated Show resolved Hide resolved
src/open_inwoner/openzaak/tests/test_cases.py Show resolved Hide resolved
@pi-sigma pi-sigma force-pushed the feature/2217-zaaktype-status-name branch from b7c43f4 to 79c90b7 Compare March 20, 2024 09:55
@pi-sigma pi-sigma requested a review from Bartvaderkin March 20, 2024 10:31
@pi-sigma pi-sigma force-pushed the feature/2217-zaaktype-status-name branch 3 times, most recently from 4d03127 to 0c74d3d Compare March 20, 2024 10:53
Bartvaderkin
Bartvaderkin suggested changes Mar 21, 2024
View reviewed changes
src/open_inwoner/utils/translate.py Outdated Show resolved Hide resolved
src/open_inwoner/openzaak/notifications.py Outdated Show resolved Hide resolved
src/open_inwoner/userfeed/hooks/case_status.py Outdated Show resolved Hide resolved
@pi-sigma pi-sigma force-pushed the feature/2217-zaaktype-status-name branch from 0c74d3d to 3f7aa26 Compare March 21, 2024 10:26
@pi-sigma pi-sigma requested a review from Bartvaderkin March 21, 2024 11:42
@pi-sigma pi-sigma force-pushed the feature/2217-zaaktype-status-name branch 2 times, most recently from 49fc679 to 181c25c Compare March 21, 2024 15:13
@alextreme
Copy link
Member

alextreme commented Mar 25, 2024 •
edited
Loading

  • Doublecheck that the emailnotification for a case statuschange has the statustekst instead of omschrijving
  • Check the userfeed
  • Check mijnaanvragen detail view: current and previous statusses

@pi-sigma pi-sigma force-pushed the feature/2217-zaaktype-status-name branch from 181c25c to 3cf2051 Compare March 25, 2024 11:27
@pi-sigma pi-sigma requested a review from Bartvaderkin March 25, 2024 12:54
@alextreme alextreme merged commit 926c4c0 into develop Mar 26, 2024
15 checks passed
@alextreme alextreme deleted the feature/2217-zaaktype-status-name branch March 26, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bartvaderkin Bartvaderkin Bartvaderkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pi-sigma @codecov-commenter @alextreme @Bartvaderkin