Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [#2157] Implement newsletter subscription form #1082

Merged
merged 10 commits into from
Mar 15, 2024

Conversation

stevenbal
Copy link
Contributor

@stevenbal stevenbal commented Mar 7, 2024

https://taiga.maykinmedia.nl/project/open-inwoner/us/2157

Can be tested locally by:

I introduced pydantic because:

  • because Laposta is not a ZGW API, it felt a bit strange to use zgw_consumers ZGWModels and factory for this API
  • zgw-consumers itself has an open issue to switch to pydantic (Switch to pydantic zgw-consumers#51)

@stevenbal stevenbal marked this pull request as draft March 7, 2024 16:29
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 67.04545% with 58 lines in your changes are missing coverage. Please review.

Project coverage is 94.84%. Comparing base (98dbb93) to head (e9c9107).
Report is 6 commits behind head on develop.

Files Patch % Lines
src/open_inwoner/laposta/client.py 38.29% 29 Missing ⚠️
src/open_inwoner/laposta/forms.py 36.36% 21 Missing ⚠️
src/open_inwoner/accounts/views/profile.py 54.54% 5 Missing ⚠️
src/open_inwoner/laposta/models.py 86.36% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1082      +/-   ##
===========================================
- Coverage    95.00%   94.84%   -0.16%     
===========================================
  Files          894      903       +9     
  Lines        31404    31580     +176     
===========================================
+ Hits         29834    29952     +118     
- Misses        1570     1628      +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevenbal stevenbal force-pushed the feature/2157-nieuwsbrief-mijn-profiel branch 5 times, most recently from bdc5c3a to d4d6f02 Compare March 11, 2024 13:38
@stevenbal stevenbal changed the title 🚧 [#2157] laposta integration ✨ [#2157] Implement newsletter subscription form Mar 11, 2024
@stevenbal stevenbal marked this pull request as ready for review March 11, 2024 15:24
Copy link
Contributor

@Bartvaderkin Bartvaderkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty clean and simple, Pydantic seems like a good idea.

I got some notes on some peculiarities (and some small stuff).

src/open_inwoner/laposta/tests/test_forms.py Outdated Show resolved Hide resolved
src/open_inwoner/laposta/admin.py Show resolved Hide resolved
src/open_inwoner/laposta/api_models.py Outdated Show resolved Hide resolved
src/open_inwoner/utils/time.py Outdated Show resolved Hide resolved
src/open_inwoner/laposta/admin.py Outdated Show resolved Hide resolved
src/open_inwoner/laposta/api_models.py Outdated Show resolved Hide resolved
@stevenbal stevenbal force-pushed the feature/2157-nieuwsbrief-mijn-profiel branch from 94e2e52 to 1f32899 Compare March 12, 2024 11:06
src/open_inwoner/utils/time.py Outdated Show resolved Hide resolved
src/open_inwoner/laposta/api_models.py Outdated Show resolved Hide resolved
@stevenbal stevenbal force-pushed the feature/2157-nieuwsbrief-mijn-profiel branch from 1f32899 to 918c94f Compare March 12, 2024 13:05
@stevenbal stevenbal requested a review from Bartvaderkin March 12, 2024 13:06
@stevenbal
Copy link
Contributor Author

@pi-sigma could you re-review this? :)

@stevenbal stevenbal merged commit b96c7cd into develop Mar 15, 2024
17 checks passed
@stevenbal stevenbal deleted the feature/2157-nieuwsbrief-mijn-profiel branch March 15, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants