-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [#2157] Implement newsletter subscription form #1082
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1082 +/- ##
===========================================
- Coverage 95.00% 94.84% -0.16%
===========================================
Files 894 903 +9
Lines 31404 31580 +176
===========================================
+ Hits 29834 29952 +118
- Misses 1570 1628 +58 ☔ View full report in Codecov by Sentry. |
bdc5c3a
to
d4d6f02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty clean and simple, Pydantic seems like a good idea.
I got some notes on some peculiarities (and some small stuff).
94e2e52
to
1f32899
Compare
1f32899
to
918c94f
Compare
@pi-sigma could you re-review this? :) |
https://taiga.maykinmedia.nl/project/open-inwoner/us/2157
Can be tested locally by:
Newsletters
in theProfileApphookConfig
and navigate viaMijn profiel
(or directly by navigating to http://127.0.0.1:8000/mijn-profiel/newsletters)I introduced
pydantic
because:zgw_consumers
ZGWModel
s andfactory
for this APIzgw-consumers
itself has an open issue to switch to pydantic (Switch to pydantic zgw-consumers#51)