💚 Add font files in playwright tests #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenbal
force-pushed
the
fix/disable-flaky-tests
branch
2 times, most recently
from
4cded38 to
993eddf
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1035 +/- ##
===========================================
- Coverage 94.85% 94.84% -0.01%
===========================================
Files 880 880
Lines 30719 30722 +3
===========================================
Hits 29138 29138
- Misses 1581 1584 +3 ☔ View full report in Codecov by Sentry. |
stevenbal
force-pushed
the
fix/disable-flaky-tests
branch
2 times, most recently
from
baa42b3 to
0615254
Compare
stevenbal
changed the title
There was a problem hiding this comment.
I'm fine with this, but left a comment.
If you want it today @pi-sigma could look at my comment and press the appropriate buttons.
stevenbal
force-pushed
the
fix/disable-flaky-tests
branch
from
0615254 to
f9e5062
Compare
to avoid flaky tests
stevenbal
force-pushed
the
fix/disable-flaky-tests
branch
from
f9e5062 to
4a17636
Compare
pi-sigma
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these tests seem to fail since #963 was merged, possibly related to the App.scss font-face changes