✨ [#2088] Implement Zaken search for eHerkenning users #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenbal
force-pushed
the
fix/2088-eherkenning-search-by-zaak-id
branch
from
f454636 to
faebc1f
Compare
stevenbal
force-pushed
the
fix/2088-eherkenning-search-by-zaak-id
branch
from
d063733 to
6d83c30
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1030 +/- ##
===========================================
- Coverage 94.84% 94.83% -0.01%
===========================================
Files 880 880
Lines 30725 30734 +9
===========================================
+ Hits 29141 29148 +7
- Misses 1584 1586 +2 ☔ View full report in Codecov by Sentry. |
Bartvaderkin
suggested changes
Feb 16, 2024
stevenbal
force-pushed
the
fix/2088-eherkenning-search-by-zaak-id
branch
2 times, most recently
from
2f2654b to
6f7a4c9
Compare
stevenbal
force-pushed
the
fix/2088-eherkenning-search-by-zaak-id
branch
from
6f7a4c9 to
152a665
Compare
to avoid repeating the same logic to determine the fetch parameters
stevenbal
force-pushed
the
fix/2088-eherkenning-search-by-zaak-id
branch
from
152a665 to
47a7373
Compare
Bartvaderkin
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: https://taiga.maykinmedia.nl/project/open-inwoner/issue/2088