Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 [#2111] Fix case-card icons and adjust card headings #1025

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

jiromaykin
Copy link
Contributor

@jiromaykin jiromaykin commented Feb 13, 2024

issue: https://taiga.maykinmedia.nl/project/open-inwoner/task/2111

  1. aligning 'Mijn aanvragen' icons optically to new line-height (even if they are correctly aligned, you might see an "optical illusion" where triangular shaped icons look different from the rest)
  2. adjusting all card-headings + give them meaningful classnames
optical-illusion

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b4d6777) 94.85% compared to head (41472bf) 94.85%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1025   +/-   ##
========================================
  Coverage    94.85%   94.85%           
========================================
  Files          880      880           
  Lines        30719    30719           
========================================
  Hits         29138    29138           
  Misses        1581     1581           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiromaykin jiromaykin force-pushed the fix/2111-fix-card-icons-and-headings branch from 2c730d8 to f8fb476 Compare February 15, 2024 09:21
@jiromaykin jiromaykin force-pushed the fix/2111-fix-card-icons-and-headings branch from 354f9ea to 47300d4 Compare February 15, 2024 15:10
@jiromaykin jiromaykin marked this pull request as ready for review February 15, 2024 15:10
@jiromaykin jiromaykin changed the title 💄 [#2111] Fix case-card headers and adjust card heading fonts 💄 [#2111] Fix case-card icons and adjust card headings Feb 15, 2024
@jiromaykin
Copy link
Contributor Author

@pi-sigma @stevenbal The 1 test that is failing here (multiple upload) is unrelated to what I've hanged here...

@alextreme alextreme merged commit 7ec1fdb into develop Feb 15, 2024
13 of 14 checks passed
@alextreme alextreme deleted the fix/2111-fix-card-icons-and-headings branch February 15, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants