Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1808] Use long month names consistently in ssd templates #1020

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

pi-sigma
Copy link
Contributor

Taiga: #1808

  • set empty title in PDF templates to prevent duplication of report name in tab
  • use long month name in case no reports are found

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7f74686) 94.79% compared to head (32f9589) 94.79%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1020   +/-   ##
========================================
  Coverage    94.79%   94.79%           
========================================
  Files          871      871           
  Lines        30557    30557           
========================================
  Hits         28966    28966           
  Misses        1591     1591           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi-sigma pi-sigma marked this pull request as ready for review February 15, 2024 08:56
@stevenbal stevenbal self-requested a review February 19, 2024 08:57
Comment on lines 5 to 7
<head>
<title></title>
</head>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this added?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title is duplicated in case a new tab is opened for file download (at least on Firefox). Apparently it is not (yet) standardized what browsers do with the title. The <title><title> effectively re-sets whatever the browser does with the title, afterwards we define our custom title. It's a hack, but I don't know a better way to deal with this. Perhaps @jiromaykin has some idea about this. I did however remove the extra head, which was an oversight.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with Jiro, I'll revert changes and create a separate issue for this because it's an accessibility issue.

src/open_inwoner/ssd/tests/test_views.py Show resolved Hide resolved
@pi-sigma pi-sigma force-pushed the fix/1808-maandspecificatie-header branch 2 times, most recently from 06b0e3f to 7eb67c7 Compare February 19, 2024 11:37
@pi-sigma pi-sigma force-pushed the fix/1808-maandspecificatie-header branch from 7eb67c7 to 922b679 Compare February 19, 2024 11:37
@stevenbal
Copy link
Contributor

@pi-sigma is this PR ready for re-review?

@pi-sigma
Copy link
Contributor Author

@ Steven Yes, this one is ready, forgot to re-request.

@pi-sigma pi-sigma requested a review from stevenbal February 22, 2024 12:01
@stevenbal stevenbal merged commit 5e6f11e into develop Feb 22, 2024
15 checks passed
@stevenbal stevenbal deleted the fix/1808-maandspecificatie-header branch February 22, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants