-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1808] Use long month names consistently in ssd templates #1020
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1020 +/- ##
========================================
Coverage 94.79% 94.79%
========================================
Files 871 871
Lines 30557 30557
========================================
Hits 28966 28966
Misses 1591 1591 ☔ View full report in Codecov by Sentry. |
<head> | ||
<title></title> | ||
</head> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title is duplicated in case a new tab is opened for file download (at least on Firefox). Apparently it is not (yet) standardized what browsers do with the title. The <title><title>
effectively re-sets whatever the browser does with the title, afterwards we define our custom title. It's a hack, but I don't know a better way to deal with this. Perhaps @jiromaykin has some idea about this. I did however remove the extra head
, which was an oversight.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed with Jiro, I'll revert changes and create a separate issue for this because it's an accessibility issue.
06b0e3f
to
7eb67c7
Compare
7eb67c7
to
922b679
Compare
@pi-sigma is this PR ready for re-review? |
@ Steven Yes, this one is ready, forgot to re-request. |
Taiga: #1808