Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡ [#2089] Use multithreading for Mijn Aanvragen list #1015

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

stevenbal
Copy link
Contributor

@stevenbal stevenbal commented Feb 9, 2024

@stevenbal stevenbal marked this pull request as draft February 9, 2024 09:56
@stevenbal stevenbal force-pushed the fix/2089-mijn-aanvragen-parallel branch 5 times, most recently from 5506df7 to bdbd2ce Compare February 9, 2024 14:53
Base automatically changed from fix/2060-replace-get-paginated-results to develop February 12, 2024 10:06
@stevenbal stevenbal force-pushed the fix/2089-mijn-aanvragen-parallel branch 4 times, most recently from c4412a4 to ecec9b6 Compare February 12, 2024 14:50
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7f74686) 94.79% compared to head (ecec9b6) 94.79%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1015   +/-   ##
========================================
  Coverage    94.79%   94.79%           
========================================
  Files          871      871           
  Lines        30557    30582   +25     
========================================
+ Hits         28966    28991   +25     
  Misses        1591     1591           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevenbal stevenbal marked this pull request as ready for review February 12, 2024 15:54
@alextreme alextreme requested a review from pi-sigma February 12, 2024 17:25
@alextreme
Copy link
Member

Surprised it didn't cause more problems with the testsuite 🙈
What do you think @pi-sigma and @Bartvaderkin ?

@stevenbal stevenbal force-pushed the fix/2089-mijn-aanvragen-parallel branch from ecec9b6 to 40d48dd Compare February 13, 2024 11:00
Copy link
Contributor

@Bartvaderkin Bartvaderkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Threading can be spicy but let's go for it.

@alextreme alextreme merged commit eaf617e into develop Feb 14, 2024
14 checks passed
@alextreme alextreme deleted the fix/2089-mijn-aanvragen-parallel branch February 14, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants