Merge pull request #458 from maykinmedia/issue-1073-productfinder-no-…

…conditions

[#1073] Fix/handle product finder empty conditions

src/open_inwoner/pdc/tests/test_product_finder.py

@@ -5,6 +5,7 @@
 
 from open_inwoner.accounts.tests.factories import UserFactory
 
+from ..models import ProductCondition
 from .factories import ProductConditionFactory, ProductFactory
 
 
@@ -1547,3 +1548,21 @@ def test_q1_no_q2_no_q3_no_q4_no(self):
         self.assertIn(self.product11, possible_products)
         self.assertNotIn(self.product12, matched_products)
         self.assertIn(self.product12, possible_products)
+
+    def test_product_finder_is_reset_when_no_condition(self):
+        response = self.app.get(reverse("pdc:product_finder"))
+        form = response.forms["product-finder"]
+
+        ProductCondition.objects.all().delete()
+
+        form["answer"].value = "yes"
+        response = form.submit()
+
+        self.assertRedirects(response, reverse("pdc:product_finder"))
+
+        session = self.app.session
+        response.follow()
+
+        self.assertEqual(session["product_finder"], {})
+        self.assertIsNone(session["current_condition"])
+        self.assertFalse(session["conditions_done"])

src/open_inwoner/pdc/views.py

@@ -375,6 +375,13 @@ def get_context_data(self, **kwargs):
         return context
 
     def form_valid(self, form):
+        # redirect user to reset product finder if no conditions exist
+        if not self.condition:
+            self.request.session["product_finder"] = {}
+            self.request.session["current_condition"] = None
+            self.request.session["conditions_done"] = False
+            return HttpResponseRedirect(self.get_success_url())
+
         self.set_product_condition_sessions(form.cleaned_data.get("answer"))
         next_condition = self.get_next_condition()
         if next_condition: