🔧 Changes to integrate generic settings for Open Klant #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it was already added to INSTALLED_APPS but missing from the dependencies
annashamray
approved these changes
Jun 6, 2024
annashamray
reviewed
Jun 6, 2024
| @@ -54,6 +54,7 @@ dependencies = [ | |||
| "celery>=5.2.7", | |||
| "flower>=2.0.1", | |||
| "maykin-2fa>=1.0.0", | |||
| "django-setup-configuration>=0.1.0", | |||
There was a problem hiding this comment.
Is this line intentional? It doesn't relate to the issue
There was a problem hiding this comment.
Yeah, I should have changed the title of the PR. I was making these changes to make it work for Open Klant
stevenbal
changed the title
stevenbal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for maykinmedia/open-klant#190