Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#513] Release 3.0.0 #149

Merged
merged 14 commits into from
Jan 22, 2025
Merged

[#513] Release 3.0.0 #149

merged 14 commits into from
Jan 22, 2025

Conversation

SonnyBA
Copy link
Contributor

@SonnyBA SonnyBA commented Jan 10, 2025

Partially fixes maykinmedia/objects-api#513

Changes

Adds changes required for releasing 3.0.0. This is the major release part.

src/objecttypes/conf/api.py Outdated Show resolved Hide resolved
@SonnyBA SonnyBA self-assigned this Jan 10, 2025
@SonnyBA SonnyBA marked this pull request as ready for review January 10, 2025 13:42
README.NL.rst Outdated Show resolved Hide resolved
src/objecttypes/api/v2/openapi.yaml Outdated Show resolved Hide resolved
src/objecttypes/conf/api.py Outdated Show resolved Hide resolved
@SonnyBA SonnyBA requested a review from stevenbal January 15, 2025 14:43
README.NL.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.NL.rst Outdated
@@ -36,7 +36,13 @@ Versie Release datum API specificatie
============== ============== =============================
latest n/a `ReDoc <https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/maykinmedia/objecttypes-api/master/src/objecttypes/api/v2/openapi.yaml>`_,
`Swagger <https://petstore.swagger.io/?url=https://raw.githubusercontent.com/maykinmedia/objecttypes-api/master/src/objecttypes/api/v2/openapi.yaml>`_,
(`verschillen <https://github.com/maykinmedia/objecttypes-api/compare/2.2.2..master#diff-b9c28fec6c3f3fa5cff870d24601d6ab7027520f3b084cc767aefd258cb8c40a>`_)
(`verschillen <https://github.com/maykinmedia/objecttypes-api/compare/3.0.0..master>`_)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually upon looking at this again, I'm not sure if this file was correct to begin with. It mentions version 3.0.0 and 2.3.0 and so on, but I think these correspond with the version of the application rather than the version of the API spec, because in this release branch the version of the API is 2.2.2.

It might be good to check with Joeri if this is right

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more of a problem in the Objects-API RTD documentation, see discussion. In this project I updated the README columns to include the application version instead of just version (which might confuse people, e.g is it the application version or the specification version?).

publiccode.yaml Outdated Show resolved Hide resolved
CHANGELOG.rst Outdated Show resolved Hide resolved
@SonnyBA SonnyBA merged commit 46640c0 into master Jan 22, 2025
15 checks passed
@SonnyBA SonnyBA deleted the release/3.0.0 branch January 22, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Objects / Objecttypes API release
3 participants