Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove v1 #130

Merged
merged 3 commits into from
Oct 3, 2024
Merged

remove v1 #130

merged 3 commits into from
Oct 3, 2024

Conversation

annashamray
Copy link
Collaborator

fixes maykinmedia/objects-api#453 (Objecttypes part)

@annashamray annashamray mentioned this pull request Sep 26, 2024
Closed
2 tasks
Coperh
Coperh approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@Coperh Coperh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥

There is a reference SHARING_CONFIGS_API_ROOT = "https://sharing-configs-api.example.org/api/v1/" if that matters

@annashamray
Copy link
Collaborator Author

@Coperh Sharing configs API was a small experimental API to share objecttypes via GitHub (here is the code - https://github.com/maykinmedia/sharing-configs-api)
Its endpoints are located at /api/v1, so it's correct.

@annashamray annashamray merged commit e67ae79 into master Oct 3, 2024
15 checks passed
@annashamray annashamray deleted the feature/remove-v1 branch October 3, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Coperh Coperh Coperh approved these changes

@SonnyBA SonnyBA Awaiting requested review from SonnyBA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Objects API v1
2 participants
@annashamray @Coperh