[#13] make CI jobs more consistent with open-api-framework related projects #129
Conversation
SonnyBA
requested review from
Coperh,
stevenbal,
annashamray and
bart-maykin
| @@ -38,5 +38,6 @@ pip-compile \ | |||
| --no-emit-index-url \ | |||
| --output-file requirements/dev.txt \ | |||
| "$@" \ | |||
| requirements/ci.txt \ | |||
| requirements/base.txt \ | |||
There was a problem hiding this comment.
Why is this change needed? I thought it would be faster to reuse already compiled ci.txt here?
There was a problem hiding this comment.
We could revert this and include pytest in the dev requirements for other projects 🤔 (to keep the requirements similar to the other projects). pytest is needed for projects which need to generate documentation through github actions.
There was a problem hiding this comment.
On second thought, I saw there were some dependencies in test-tools.in which were not used for development, see c5fd869#diff-341d4064347b7e95989c82d7e176e19934bea3913d05bf0b244057aaf3b3e567L3
| requirements/base.txt^ | ||
| requirements/test-tools.in^ |
There was a problem hiding this comment.
I think this file should have the same changes as bin/compile_dependencies.sh
SonnyBA
force-pushed
the
feature/13-consistent-ci-configuration
branch
from
c5fd869 to
a8472f0
Compare
|
Depends on #133 |
This reverts commit c60ffd8.
SonnyBA
force-pushed
the
feature/13-consistent-ci-configuration
branch
from
5d43ebb to
638adf4
Compare
Fixes maykinmedia/open-api-framework#13
Changes
Reuses open-api-workflows workflows to make CI jobs consistent across the different projects.